1633365 - TypeError: WeakMap key must be an object, got permanentKey

Status: RESOLVED FIXED

(Firefox :: Menus, defect, P3)

Description

[kernp25]

Attachment: firefox_Hq6sVIwlm1.png

I see this TypeError in console: WeakMap key must be an object, got permanentKey

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Hi kernp25,

I think I need more information here. What version of Firefox are you running? Did you do something immediately before the error showed up? How easy is it for you to reproduce the problem?

Comment 2

[kernp25]

Attachment: test.zip

Comment 3

[kernp25]

(In reply to Mike Conley (:mconley) (:⚙️) from comment #1)

What version of Firefox are you running?

77.0a1 (2020-04-27) (64-Bit)

How easy is it for you to reproduce the problem?

STR:

1. Load the attached add-on in about:debugging
2. Click on the browser action icon

Comment 4

[:Gijs (out for now; he/him)]

I can't reproduce with the add-on as attached on nightly from today ... the popup shows an XFO block error (mozilla.org can't be framed), and no output appears in the browser console. Does the iframe loading matter? Am I missing some steps? Does the error only appear if some other prefs are enabled? I doublechecked a second clean profile and there, too, I don't see the error.

I suspect we just need to set group: "browsers", on the page style actor, but equally, without being able to reproduce it's hard to know if that's really correct or if I'm misunderstanding the problem...

Comment 5

[kernp25]

Attachment: test_bug_1633365.zip

Now uses https://example.com/

Comment 6

[kernp25]

(In reply to :Gijs (he/him) from comment #4)

Does the iframe loading matter?

Yes! If the iframe has no src or the src is about:blank then the error will not show.

Comment 7

[kernp25]

(In reply to :Gijs (he/him) from comment #4)

I can't reproduce with the add-on as attached on nightly from today ... the popup shows an XFO block error (mozilla.org can't be framed)

The loading in iframe fix has been reverted, so that's why it was not working anymore.

Comment 8

[:Gijs (out for now; he/him)]

Attachment: Bug 1633365 - stop loading page style actors except in tabbrowser browsers, r?florian

I filed a bug for the generic version of this as bug 1635131, but we can
stop the immediate problem here by just not running this actor except
for tabbrowser browsing contexts.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/011b51a914cc
stop loading page style actors except in tabbrowser browsers, r=florian

Comment 10

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/011b51a914cc