1633396 - Don't check the blocklist for builtin/system addons

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, enhancement, P3)

Description

[Andrew Swan [:aswan]]

Follow-up from https://bugzilla.mozilla.org/show_bug.cgi?id=1625181#c13 in which Gijs says:

I think we now still do this work when a blocklist update comes in, because we ask the add-on manager for a list of all installed add-ons which (I think) includes these ones. Should we avoid updating blocklist states there, too?

Its a good point, that bug was primarily about deferring the load of Blocklist.jsm until later in startup, but this is additional unneeded work and also slightly inconsistent behavior (the fact that system addons are checked against the blocklist during updates but not during startup), lets clean this up by not checking these addons against the blocklist at all.

Comment 1

[Andrew Swan [:aswan]]

Attachment: Bug 1633396 Skip blocklist checks for system/builtin addons

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3422c3f110b
Skip blocklist checks for system/builtin addons r=zombie

Comment 3

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/a3422c3f110b