1633399 - Twitter crashes while typing Korean (likely due to a DraftJS bug)

Status: NEW

(Core :: DOM: Editor, defect, P3)

Description

[Kagami Rosylight [:saschanaz] (they/them)]

1. Access twitter.com
2. Type "가" and press enter key.
3. Tap Control+Shift+Home to select all texts including newline.
4. Type "가" again and press space key.

Expected: "가"
Actual: Twitter crashes - "Something went wrong, but don’t fret — it’s not your fault."

This also causes a bug on Chrome but it doesn't crash. I guess we need to contact Twitter.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Twitter crashes or some child process of Firefox crashes?
(I don't know what "Twitter crashes" means :) )

Maybe this is a tech evangelism bug?

Comment 2

[Kagami Rosylight [:saschanaz] (they/them)]

It's Twitter that crashes, not the Firefox tab itself. Seemingly an exception occurs from a mutation observer callback.

exports (https://abs.twimg.com/responsive-web/web/bundle.RichTextCompose.3bbd68a4.js#9)
registerMutation (https://abs.twimg.com/responsive-web/web/bundle.RichTextCompose.3bbd68a4.js#9)
registerMutations (https://abs.twimg.com/responsive-web/web/bundle.RichTextCompose.3bbd68a4.js#9)
e (https://abs.twimg.com/responsive-web/web/bundle.RichTextCompose.3bbd68a4.js#9)
e (https://abs.twimg.com/responsive-web/web/bundle.RichTextCompose.3bbd68a4.js#9)
onCompositionStart (https://abs.twimg.com/responsive-web/web/bundle.RichTextCompose.3bbd68a4.js#9)
onCompositionStart (https://abs.twimg.com/responsive-web/web/bundle.RichTextCompose.3bbd68a4.js#9)
_buildHandler (https://abs.twimg.com/responsive-web/web/bundle.RichTextCompose.3bbd68a4.js#1)
ta (https://abs.twimg.com/responsive-web/web/vendors~main.e0482f54.js#65)
unstable_runWithPriority (https://abs.twimg.com/responsive-web/web/main.82ef4e44.js#10)
ta (https://abs.twimg.com/responsive-web/web/vendors~main.e0482f54.js#65)
unstable_flushControlled (https://abs.twimg.com/responsive-web/web/vendors~main.e0482f54.js#65)
_buildHandler (https://abs.twimg.com/responsive-web/web/bundle.RichTextCompose.3bbd68a4.js#1)
exports (https://abs.twimg.com/responsive-web/web/bundle.RichTextCompose.3bbd68a4.js#9)
_buildHandler (https://abs.twimg.com/responsive-web/web/bundle.RichTextCompose.3bbd68a4.js#1)
ta (https://abs.twimg.com/responsive-web/web/vendors~main.e0482f54.js#65)
unstable_runWithPriority (https://abs.twimg.com/responsive-web/web/main.82ef4e44.js#10)
ta (https://abs.twimg.com/responsive-web/web/vendors~main.e0482f54.js#65)
unstable_flushControlled (https://abs.twimg.com/responsive-web/web/vendors~main.e0482f54.js#65)
_buildHandler (https://abs.twimg.com/responsive-web/web/bundle.RichTextCompose.3bbd68a4.js#1)
a (https://abs.twimg.com/responsive-web/web/vendors~main.e0482f54.js#65)
p (https://abs.twimg.com/responsive-web/web/vendors~main.e0482f54.js#65)
O (https://abs.twimg.com/responsive-web/web/vendors~main.e0482f54.js#65)
O (https://abs.twimg.com/responsive-web/web/vendors~main.e0482f54.js#65)
C (https://abs.twimg.com/responsive-web/web/vendors~main.e0482f54.js#65)
P (https://abs.twimg.com/responsive-web/web/vendors~main.e0482f54.js#65)
R (https://abs.twimg.com/responsive-web/web/vendors~main.e0482f54.js#65)
kn (https://abs.twimg.com/responsive-web/web/vendors~main.e0482f54.js#65)
Ia (https://abs.twimg.com/responsive-web/web/vendors~main.e0482f54.js#65)
ze (https://abs.twimg.com/responsive-web/web/vendors~main.e0482f54.js#65)
Cn (https://abs.twimg.com/responsive-web/web/vendors~main.e0482f54.js#65)
En (https://abs.twimg.com/responsive-web/web/vendors~main.e0482f54.js#65)
pr (https://abs.twimg.com/responsive-web/web/vendors~main.e0482f54.js#65)

Comment 3

[Hsin-Yi Tsai (she/her) [:hsinyi]]

This may worth webcompat team's attention.

Comment 4

[Mike Taylor [:miketaylr]]

Non-ascii text + selection reminds me of Bug 1625475... I'll email Twitter today.

Comment 5

[Mike Taylor [:miketaylr]]

Attachment: screenshot of crashed twitter tab

Here's a screenshot of what this looks like. Note: I had to install the Korean IME to get this to reproduce, it's not enough to merely copy and paste the chars.

Comment 6

[Mike Taylor [:miketaylr]]

I sent an email to our mozilla-twitter mailing list.

Comment 7

[charlie.croom]

Can you test on https://draftjs.org/ ? Look for any errors in the console. We generally just use that as our editor without too many frills on top, so any issues are likely with that editor itself. We're a minor version behind, so it's possible upgrading might help.

Comment 8

[Mike Taylor [:miketaylr]]

Attachment: screenshot of draftjs demo

OK, yeah. I think Twitter is off the hook, this manages to nuke the entire DraftJS page. :)

Comment 9

[Mike Taylor [:miketaylr]]

I filed https://github.com/facebook/draft-js/issues/2412.

Comment 10

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Masayuki, is this another variant of bug 1739489?

Comment 11

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #10)

Masayuki, is this another variant of bug 1739489?

Could be, but not directly same thing since Windows does not use the new path for inputting commit string without composition events.

Comment 12

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Kagami, do you still see this issue?

Comment 13

[Kagami Rosylight [:saschanaz] (they/them)]

Yes, but it does not crash anymore but instead cleans all the text away unexpectedly.

Comment 14

[Kagami Rosylight [:saschanaz] (they/them)]

(Still reproducible. Just wanted to say as there's a new see-also)

Comment 15

[Wayne Roberts]

Attachment: same problem

Thanks from dosencatsli1975.