Closed Bug 1633448 Opened 5 years ago Closed 5 years ago

Factor selection of range's frames from `Selection` out

Tracking

()

Status:

RESOLVED FIXED

People

(Reporter: mbrodesser, Assigned: mbrodesser)

References

(Blocks 1 open bug)

Details

Attachments

(11 files, 1 obsolete file)

Bug 1633448: part 1) Move `Selection::SubtractRange` to `StyledRanges`. r=smaug 5 years ago Mirko Brodesser (:mbrodesser) -- not reading bugmails currently 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1633448: part 2) Rename `nsFrameSelection::GetTableCellSelection` to `IsInTableSelectionMode`. r=smaug 5 years ago Mirko Brodesser (:mbrodesser) -- not reading bugmails currently 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1633448: part 3) Annotate `Selection::AddRangesForUserSelectableNodes` with `MOZ_CAN_RUN_SCRIPT`. r=smaug 5 years ago Mirko Brodesser (:mbrodesser) -- not reading bugmails currently 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1633448: part 4) Annotate `Selection::SetAnchorFocusToRange` with `MOZ_CAN_RUN_SCRIPT`. r=smaug 5 years ago Mirko Brodesser (:mbrodesser) -- not reading bugmails currently 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1633448: part 5) Move range-frame-selection related code to `RangeFramesSelector`. r=smaug 5 years ago Mirko Brodesser (:mbrodesser) -- not reading bugmails currently 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1633448: part 5) Rename `AreUserSelectedRangesNonEmpty` to `IsUserSelectionNotCollapsed`. r=hsivonen 5 years ago Mirko Brodesser (:mbrodesser) -- not reading bugmails currently 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1633448: part 6) Change `IsUserSelectionNotCollapsed` to `IsUserSelectionCollapsed`. r=hsivonen 5 years ago Mirko Brodesser (:mbrodesser) -- not reading bugmails currently 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1633448: part 7) Add `StyledRanges::UnregisterSelection`. r=hsivonen 5 years ago Mirko Brodesser (:mbrodesser) -- not reading bugmails currently 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1633448: part 8) Add `StyledRanges::RemoveCollapsedRanges`. r=hsivonen 5 years ago Mirko Brodesser (:mbrodesser) -- not reading bugmails currently 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1633448: part 9) Add `StyledRanges::Length`. r=hsivonen 5 years ago Mirko Brodesser (:mbrodesser) -- not reading bugmails currently 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1633448: part 10) Add `StyledRanges::Clear`. r=hsivonen 5 years ago Mirko Brodesser (:mbrodesser) -- not reading bugmails currently 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1633448: part 11) Add const-correctness to `Selection::CollapseToStart` and `CollapseToEnd`. r=hsivonen 5 years ago Mirko Brodesser (:mbrodesser) -- not reading bugmails currently 47 bytes, text/x-phabricator-request		Details \| Review

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Description

•

5 years ago

No description provided.

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 1

•

5 years ago

Attached file Bug 1633448: part 1) Move `Selection::SubtractRange` to `StyledRanges`. r=smaug — Details

StyledRanges should have as few dependencies to Selection` as
possible.

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 2

•

5 years ago

Attached file Bug 1633448: part 2) Rename `nsFrameSelection::GetTableCellSelection` to `IsInTableSelectionMode`. r=smaug — Details

Depends on D72688

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Updated

•

5 years ago

Keywords: leave-open

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Updated

•

5 years ago

Blocks: 1590379

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 3

•

5 years ago

Attached file Bug 1633448: part 3) Annotate `Selection::AddRangesForUserSelectableNodes` with `MOZ_CAN_RUN_SCRIPT`. r=smaug — Details

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 4

•

5 years ago

Attached file Bug 1633448: part 4) Annotate `Selection::SetAnchorFocusToRange` with `MOZ_CAN_RUN_SCRIPT`. r=smaug — Details

Depends on D72803

Pulsebot

Comment 5

•

5 years ago

Pushed by mbrodesser@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bdedc2f618ce part 1) Move `Selection::SubtractRange` to `StyledRanges`. r=smaug https://hg.mozilla.org/integration/autoland/rev/be7f0794dc53 part 2) Rename `nsFrameSelection::GetTableCellSelection` to `IsInTableSelectionMode`. r=smaug

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 6

•

5 years ago

Attached file Bug 1633448: part 5) Move range-frame-selection related code to `RangeFramesSelector`. r=smaug (obsolete) — Details

Simplifies reasoning about it.

Arthur Iakab [arthur_iakab]

Comment 7

•

5 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/bdedc2f618ce
https://hg.mozilla.org/mozilla-central/rev/be7f0794dc53

Pulsebot

Comment 8

•

5 years ago

Pushed by mbrodesser@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d0207e9fef5f part 3) Annotate `Selection::AddRangesForUserSelectableNodes` with `MOZ_CAN_RUN_SCRIPT`. r=smaug https://hg.mozilla.org/integration/autoland/rev/565d44023c35 part 4) Annotate `Selection::SetAnchorFocusToRange` with `MOZ_CAN_RUN_SCRIPT`. r=smaug

Cosmin Sabou [:CosminS]

Comment 9

•

5 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/d0207e9fef5f
https://hg.mozilla.org/mozilla-central/rev/565d44023c35

Phabricator Automation

Updated

•

5 years ago

Attachment #9143936 - Attachment is obsolete: true

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 10

•

5 years ago

Attached file Bug 1633448: part 5) Rename `AreUserSelectedRangesNonEmpty` to `IsUserSelectionNotCollapsed`. r=hsivonen — Details

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 11

•

5 years ago

Attached file Bug 1633448: part 6) Change `IsUserSelectionNotCollapsed` to `IsUserSelectionCollapsed`. r=hsivonen — Details

Removes unnecessary double negations.

Depends on D73233

Phabricator Automation

Updated

•

5 years ago

Attachment #9144618 - Attachment is obsolete: true

Phabricator Automation

Updated

•

5 years ago

Attachment #9144619 - Attachment is obsolete: true

Phabricator Automation

Updated

•

5 years ago

Attachment #9144618 - Attachment description: Bug 1633448: part 5) Rename `AreUserSelectedRangesNonEmpty` to `AreUserSelectedRangesNotCollapsed`. r=hsivonen → Bug 1633448: part 5) Rename `AreUserSelectedRangesNonEmpty` to `IsUserSelectionNotCollapsed`. r=hsivonen

Attachment #9144618 - Attachment is obsolete: false

Phabricator Automation

Updated

•

5 years ago

Attachment #9144619 - Attachment description: Bug 1633448: part 6) Change `AreUserSelectedRangesNotCollapsed` to `AreUserSelectedRangesCollapsed`. r=hsivonen → Bug 1633448: part 6) Change `IsUserSelectionNotCollapsed` to `IsUserSelectionCollapsed`. r=hsivonen

Attachment #9144619 - Attachment is obsolete: false

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 12

•

5 years ago

Attached file Bug 1633448: part 7) Add `StyledRanges::UnregisterSelection`. r=hsivonen — Details

One step closer towards privatizing StyledRanges::mRanges.

Depends on D73234

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 13

•

5 years ago

Attached file Bug 1633448: part 8) Add `StyledRanges::RemoveCollapsedRanges`. r=hsivonen — Details

Another step towards privatizing StyledRanges::mRanges.

Depends on D73430

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 14

•

5 years ago

Attached file Bug 1633448: part 9) Add `StyledRanges::Length`. r=hsivonen — Details

Another step towards privatizing StyledRanges::mRanges.

Depends on D73431

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 15

•

5 years ago

Attached file Bug 1633448: part 10) Add `StyledRanges::Clear`. r=hsivonen — Details

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 16

•

5 years ago

Attached file Bug 1633448: part 11) Add const-correctness to `Selection::CollapseToStart` and `CollapseToEnd`. r=hsivonen — Details

Depends on D73433

Hsin-Yi Tsai (she/her) [:hsinyi]

Updated

•

5 years ago

Severity: -- → N/A

Pulsebot

Comment 17

•

5 years ago

Pushed by mbrodesser@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/37af395d6c4b part 5) Rename `AreUserSelectedRangesNonEmpty` to `IsUserSelectionNotCollapsed`. r=hsivonen https://hg.mozilla.org/integration/autoland/rev/a72df7663097 part 6) Change `IsUserSelectionNotCollapsed` to `IsUserSelectionCollapsed`. r=hsivonen https://hg.mozilla.org/integration/autoland/rev/31d02fd49e39 part 7) Add `StyledRanges::UnregisterSelection`. r=hsivonen https://hg.mozilla.org/integration/autoland/rev/e466df4c63ba part 8) Add `StyledRanges::RemoveCollapsedRanges`. r=hsivonen https://hg.mozilla.org/integration/autoland/rev/6f330ee972e0 part 9) Add `StyledRanges::Length`. r=hsivonen https://hg.mozilla.org/integration/autoland/rev/1c427c423a5b part 10) Add `StyledRanges::Clear`. r=hsivonen https://hg.mozilla.org/integration/autoland/rev/08af3903c219 part 11) Add const-correctness to `Selection::CollapseToStart` and `CollapseToEnd`. r=hsivonen

Andreea Pavel [:apavel]

Comment 18

•

5 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/37af395d6c4b
https://hg.mozilla.org/mozilla-central/rev/a72df7663097
https://hg.mozilla.org/mozilla-central/rev/31d02fd49e39
https://hg.mozilla.org/mozilla-central/rev/e466df4c63ba
https://hg.mozilla.org/mozilla-central/rev/6f330ee972e0
https://hg.mozilla.org/mozilla-central/rev/1c427c423a5b
https://hg.mozilla.org/mozilla-central/rev/08af3903c219

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 19

•

5 years ago

Won't have time to continue working on this soon. Will open a new ticket when I continue.

Status: NEW → RESOLVED

Closed: 5 years ago

Resolution: --- → FIXED

BugBot [:suhaib / :marco/ :calixte]

Updated

•

5 years ago

Keywords: leave-open

You need to log in before you can comment on or make changes to this bug.