1633502 - Remote settings spamming console with HTTP 400 errors from Kinto

Status: RESOLVED FIXED

(Firefox :: Remote Settings Client, defect, P1)

Description

[Mats Palmgren (inactive)]

I'm seeing a lot of this console spam in my local build recently:

console.error: services.settings: 
ServerResponse
    - fileName = resource://services-common/kinto-http-client.js
    - lineNumber = 454
    - columnNumber = 13
    - message = HTTP 400 Invalid parameters: Invalid request parameter (_since in querystring: The value should be integer between double quotes.)
    - response = Response {}
    - data = {"code":400,"errno":107,"error":"Invalid parameters","message":"_since in querystring: The value should be integer between double quotes.","details":[{"location":"querystring","name":"_since","description":"The value should be integer between double quotes."}]}

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[:Harald Kirschner :digitarald]

Setting Sync as component, as Kinto is mentioned in the logs.

(Console doesn't own those logs and I am not sure if we should make it harder to log.)

Comment 3

[Ryan Kelly [:rfkelly]]

Thanks Harald; I believe "Remote Settings Client" is a better component component in this case since the log mentions "services.settings".

Comment 4

[Ryan Kelly [:rfkelly]]

I spotted a bunch of these in my browser console just now, they were associated with outgoing requests like:

GET https://firefox.settings.services.mozilla.com/v1/buckets/main/collections/normandy-recipes-capabilities/changeset?_expected=1588118295814&_since=1588003789852

In which, indeed, the _since parameter is not surrounded by double quotes. Interestingly I do see some other requests in which _since is quote, such as:

GET https://firefox.settings.services.mozilla.com/v1/buckets/monitor/collections/changes/records?_since=%221588017004720%22&_expected=%221588118478742%22

Comment 5

[Mark Banner (:standard8)]

I've just reproduced this via this route:

• Install Remote Settings devtools
• Clear all local data
• wait a bit for that to happen
• Poll Server

It seems to happen on blocklists/addons in that case. Though I've also seen it in other cases when switching servers & clearing/polling data.

Clearing Severity field as I don't think minor is necessarily right depending on what this is actually affecting.

Comment 6

[Mathieu Leplatre [:leplatrem]]

I wonder why I didn't get notified earlier.

This is very likely to be a regression introduced by Bug 1620186

This is a heavy P1 but fortunately the fix is trivial.

Comment 7

[Mathieu Leplatre [:leplatrem]]

Attachment: Bug 1633502 - Fix usage of timestamp in changeset querystring r?mythmon

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9883e152cebd
Fix usage of timestamp in changeset querystring r=mythmon

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/9883e152cebd