Closed Bug 1633517 Opened 5 years ago Closed 5 years ago

Refinements to DevTools message editing feature

Categories

(Firefox :: Messaging System, enhancement, P2)

Product:
Firefox
Component:
Messaging System
Type:
enhancement

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 79
Iteration:
79.1 - June 1 - June 14
Tracking Flags:
Tracking Status
firefox78 --- wontfix
firefox79 --- verified

People

(Reporter: emcminn, Assigned: emcminn)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1633517 - Added impression param to forceShowMessage, refactored/cleaned up 'Modify', filtered messages on content.body
47 bytes, text/x-phabricator-request
Details | Review

As a followup to 1614364, we can work on the following:

  1. Clicking Modify Template, after selecting multiple messages, only loads a single modified message. Ideally it should continue displaying all selected messages

  2. Intermittent failure seen while rendering message, displaying text as Invalid Date

  3. Click of Modify Template in DevTools shouldn't send Telemetry Impression ping

Iteration: --- → 78.1 - May 4 - May 17
status-firefox78: --- → affected
Priority: -- → P2
Blocks: fxms-devtools
Attachment #9147992 - Attachment description: Bug 1633517 - Added impression param to forceShowMessage, 'Modify' keeps rendered messages in the WNPanel, disabled message items with no published_date → Bug 1633517 - Added impression param to forceShowMessage, refactored/cleaned up 'Modify', disabled message items with no published_date
Iteration: 78.1 - May 4 - May 17 → 78.2 - May 18 - May 31

Click of Modify Template in DevTools shouldn't send Telemetry Impression ping

I think handling this scenario complicates the overall logic. Why do we want to prevent these pings?

Flags: needinfo?(emcminn)

(In reply to Andrei Oprea [:andreio] from comment #2)

Click of Modify Template in DevTools shouldn't send Telemetry Impression ping

I think handling this scenario complicates the overall logic. Why do we want to prevent these pings?

I think just to prevent skewing the telemetry, especially if we're going to open up devTools for experimentation (i.e. we don't want to send a new ping every time someone modifies and tests a message, especially if they're trying many different things.)

Flags: needinfo?(emcminn)
Iteration: 78.2 - May 18 - May 31 → 79.1 - June 1 - June 14
Attachment #9147992 - Attachment description: Bug 1633517 - Added impression param to forceShowMessage, refactored/cleaned up 'Modify', disabled message items with no published_date → Bug 1633517 - Added impression param to forceShowMessage, refactored/cleaned up 'Modify', filtered messages on content.body
Pushed by emcminn@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/33f0b54b388d Added impression param to forceShowMessage, refactored/cleaned up 'Modify', filtered messages on content.body r=andreio

https://hg.mozilla.org/mozilla-central/rev/33f0b54b388d

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox79: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 79

I have verified this enhancement and I can confirm the following:
- The "Modify Template" button is no longer displayed in the "about:newtab#devtools-wnpanel" page.
- The "Invalid Date" string is no longer displayed in the "What's New" panel.

Verified using the latest Firefox Nightly (79.0az Build ID - 20200623034439) installed on Windows 10 x64, Mac 10.15, and Ubuntu 18.04 x64.

Status: RESOLVED → VERIFIED
status-firefox79: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: