1633527 - Modernize C++ in JitRuntime

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P3)

Description

[Ted Campbell [:tcampbell]]

Use field initializers in JitRuntime to avoid mistakes. Eg. JitRuntime::disambiguationId_ was never initialized.

Comment 1

[Ted Campbell [:tcampbell]]

Attachment: Bug 1633527 - Use field initializers in JitRuntime. r?iain

This also makes sure disambiguationId_ is properly initialized.

Comment 2

[Ted Campbell [:tcampbell]]

Attachment: Bug 1633527 - Cleanup typedefs in JitRuntime. r?iain

Depends on D72735

Comment 3

[Ted Campbell [:tcampbell]]

(This was to fix some static-analysis complaints ./mach static-analysis check js/src/jit/Ion.cpp)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e63cd75d1774
Use field initializers in JitRuntime. r=iain
https://hg.mozilla.org/integration/autoland/rev/6781a7371f6e
Cleanup typedefs in JitRuntime. r=iain

Comment 5

[Razvan Maries]

Backed out for perma failures on test_ext_geckoProfiler_control.js.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=POqw1ra6Qvm0sYTPAIe_0Q-0&resultStatus=testfailed%2Cbusted%2Cexception&revision=6781a7371f6e4b1b27a51c8659406a8bf40e1d99

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=299651113&repo=autoland&lineNumber=5825

Backout: https://hg.mozilla.org/integration/autoland/rev/2b2c615bbe262851bfad84cd6e6bb2d46967e867

Comment 6

[Ted Campbell [:tcampbell]]

Looks like the profiler accesses the BaselineInterpreter off-thread. I'm gonna drop the second patch.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/41cb3b484ef7
Use field initializers in JitRuntime. r=iain

Comment 8

[Andreea Pavel [:apavel]]

Also caused devtools and mochitest chrome crash: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=6781a7371f6e4b1b27a51c8659406a8bf40e1d99&selectedTaskRun=HERZ6NMwRtKW19a-gZNOlA-0

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=299649725&repo=autoland&lineNumber=3194

Comment 9

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/41cb3b484ef7