1633625 - Make a GC microbenchmark shell test suite

Status: RESOLVED FIXED

(Core :: JavaScript: GC, enhancement, P3)

Description

[Steve Fink [:sfink] [:s:]]

Finally going to start trickling these patches in.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1633625 - gc-ubench UI improvements

Comment 2

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1633625 - Consolidate some timing code into FrameTimer

Comment 3

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1633625 - Load gc-ubench test loads from a file listing

Comment 4

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1633625 - Split out shared benchmark harness from HTML UI. Summary metric computation is still in the UI for now.

Comment 5

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1633625 - Move load management into a global AllocationLoadManager

Comment 6

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1633625 - Move FrameTimer to ui.js since the "tests" are still exclusive to the web UI for now

Comment 7

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1633625 - Reformat to eslint style

Comment 8

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1633625 - Complete the renaming of "garbage total" to "garbage piles"

Comment 9

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1633625 - Move load parameters into the appropriate part of the web UI

Comment 10

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1633625 - Extract out a load cycle manager

Comment 11

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1633625 - Changed how allocation loads are started/stopped

Comment 12

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1633625 - Drop default #garbage piles from 8 million to 8.

Comment 13

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1633625 - Redo how load parameters are displayed, and fix invalid inputs for them

Comment 14

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1633625 - Wrap timing code up in a FrameHistory class

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ee7b677a58d4
Reformat to eslint style
https://hg.mozilla.org/integration/autoland/rev/25677e1e8ae9
gc-ubench UI improvements r=jonco
https://hg.mozilla.org/integration/autoland/rev/228c0a6a6fa5
Consolidate some timing code into FrameTimer r=jonco
https://hg.mozilla.org/integration/autoland/rev/5fa27a3eb904
Load gc-ubench test loads from a file listing r=jonco
https://hg.mozilla.org/integration/autoland/rev/f2f85c9314d9
Split out shared benchmark harness from HTML UI. Summary metric computation is still in the UI for now. r=jonco
https://hg.mozilla.org/integration/autoland/rev/01c15698c52e
Move load management into a global AllocationLoadManager r=jonco
https://hg.mozilla.org/integration/autoland/rev/11f931f75953
Move FrameTimer to ui.js since the "tests" are still exclusive to the web UI for now r=jonco

Comment 16

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/ee7b677a58d4
https://hg.mozilla.org/mozilla-central/rev/25677e1e8ae9
https://hg.mozilla.org/mozilla-central/rev/228c0a6a6fa5
https://hg.mozilla.org/mozilla-central/rev/5fa27a3eb904
https://hg.mozilla.org/mozilla-central/rev/f2f85c9314d9
https://hg.mozilla.org/mozilla-central/rev/01c15698c52e
https://hg.mozilla.org/mozilla-central/rev/11f931f75953

Comment 17

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1633625 - Record malloc bytes (from the zone only)

Comment 18

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1633625 - Implement a performance.mozMemory.mallocBytes accessor for all-zones malloc memory

Comment 19

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1633625 - Convert Graph and subclasses into JS classes

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e2e7b5d4a80
Complete the renaming of "garbage total" to "garbage piles" r=jonco
https://hg.mozilla.org/integration/autoland/rev/05f1caf2067e
Move load parameters into the appropriate part of the web UI r=jonco
https://hg.mozilla.org/integration/autoland/rev/9f781166ebe7
Extract out a load cycle manager r=jonco
https://hg.mozilla.org/integration/autoland/rev/69515a716bc5
Changed how allocation loads are started/stopped r=jonco
https://hg.mozilla.org/integration/autoland/rev/e64e2d20b81b
Drop default #garbage piles from 8 million to 8. r=jonco
https://hg.mozilla.org/integration/autoland/rev/e1122eb68511
Redo how load parameters are displayed, and fix invalid inputs for them r=jonco
https://hg.mozilla.org/integration/autoland/rev/a8c6fc87c62b
Wrap timing code up in a FrameHistory class r=jonco

Comment 21

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1633625 - move performance.mozMemory -> performance.mozMemory.gc to match the JS shell, and because performance.mozMemory.mallocBytes is deceptive when it only refers to GC-controlled malloc bytes

Comment 22

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/2e2e7b5d4a80
https://hg.mozilla.org/mozilla-central/rev/05f1caf2067e
https://hg.mozilla.org/mozilla-central/rev/9f781166ebe7
https://hg.mozilla.org/mozilla-central/rev/69515a716bc5
https://hg.mozilla.org/mozilla-central/rev/e64e2d20b81b
https://hg.mozilla.org/mozilla-central/rev/e1122eb68511
https://hg.mozilla.org/mozilla-central/rev/a8c6fc87c62b

Comment 23

[Steve Fink [:sfink] [:s:]]

Oops, forgot the leave-open flag yet again.

Comment 24

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1633625 - Make noAllocation mutator load less special

Comment 25

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1633625 - Allow mutator loads to be disabled (presumably based on environment)

Comment 26

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1633625 - Add new "deepWeakMap" mutator load

Comment 27

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1633625 - Make class declarations reloadable

Comment 28

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1633625 - Basic shell harness for running the GC microbenchmarks

Comment 29

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1633625 - Split out host-provided functionality (currently SpiderMonkey and Firefox)

Comment 30

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1633625 - Substring matching on mutators passed on command line

Comment 31

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1633625 - Expose a maybegc() testing function

Comment 32

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1633625 - Call clearKeptObjects before drainJobQueue.

It makes more sense to clearKeptObjects to make things collectable, then do a collection, and then run any finalizations as part of drainJobQueue.

Comment 33

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1633625 - Add a V8 shell runner

Comment 34

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1633625 - Create a PerfTracker class that monitors the execution and computes performance results.

Comment 35

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1633625 - Implement a command-line argument parser modeled on Python's argparse

Comment 36

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1633625 - Split out schedulers and choose via command line argument --sched

Comment 37

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1633625 - Implement --duration/-d command line option.

Comment 38

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1633625 - Adjust garbagePerFrame to around 50% 60fps frame drops on my laptop

Comment 39

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1633625 - Split out a sequencer object.

Comment 40

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1633625 - Replace LoadCycle sequencer with a more general ChainSequencer.

Comment 41

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1633625 - Use mutator objects instead of names (minor refactor).

Comment 42

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1633625 - Eliminate events in favor of pushing start/end control down into sequencers.

Comment 43

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1633625 - Implement a Find50Sequencer that searches for the garbagePerFrame resulting in 50% frame drop at 60fps

Comment 44

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/97079b757b57
move performance.mozMemory -> performance.mozMemory.gc to match the JS shell, and because performance.mozMemory.mallocBytes is deceptive when it only refers to GC-controlled malloc bytes r=jonco,smaug
https://hg.mozilla.org/integration/autoland/rev/b0e7c0beb052
Record malloc bytes (from the zone only) r=jonco
https://hg.mozilla.org/integration/autoland/rev/d7e1fb886446
Implement a performance.mozMemory.mallocBytes accessor for all-zones malloc memory r=jonco
https://hg.mozilla.org/integration/autoland/rev/51e3676256c7
Convert Graph and subclasses into JS classes r=jonco
https://hg.mozilla.org/integration/autoland/rev/e04b67a3ac24
Make noAllocation mutator load less special r=jonco
https://hg.mozilla.org/integration/autoland/rev/7e985178f7dc
Allow mutator loads to be disabled (presumably based on environment) r=jonco
https://hg.mozilla.org/integration/autoland/rev/28980e6af06f
Add new "deepWeakMap" mutator load r=jonco
https://hg.mozilla.org/integration/autoland/rev/6fd685c690a8
Make class declarations reloadable r=jonco
https://hg.mozilla.org/integration/autoland/rev/462f792e609d
Basic shell harness for running the GC microbenchmarks r=jonco
https://hg.mozilla.org/integration/autoland/rev/6c6d07b53773
Split out host-provided functionality (currently SpiderMonkey and Firefox) r=jonco
https://hg.mozilla.org/integration/autoland/rev/1a7da96bca66
Substring matching on mutators passed on command line r=jonco
https://hg.mozilla.org/integration/autoland/rev/70d5de256f8b
Expose a maybegc() testing function r=jonco
https://hg.mozilla.org/integration/autoland/rev/16b7d6a72288
Call clearKeptObjects before drainJobQueue. r=jonco
https://hg.mozilla.org/integration/autoland/rev/cc9e3394bf4f
Add a V8 shell runner r=jonco
https://hg.mozilla.org/integration/autoland/rev/37f859f3252e
Create a PerfTracker class that monitors the execution and computes performance results. r=jonco
https://hg.mozilla.org/integration/autoland/rev/a57b374c5f80
Implement a command-line argument parser modeled on Python's argparse r=jonco
https://hg.mozilla.org/integration/autoland/rev/9e31e7bd21c0
Split out schedulers and choose via command line argument --sched r=jonco

Comment 45

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/97079b757b57
https://hg.mozilla.org/mozilla-central/rev/b0e7c0beb052
https://hg.mozilla.org/mozilla-central/rev/d7e1fb886446
https://hg.mozilla.org/mozilla-central/rev/51e3676256c7
https://hg.mozilla.org/mozilla-central/rev/e04b67a3ac24
https://hg.mozilla.org/mozilla-central/rev/7e985178f7dc
https://hg.mozilla.org/mozilla-central/rev/28980e6af06f
https://hg.mozilla.org/mozilla-central/rev/6fd685c690a8
https://hg.mozilla.org/mozilla-central/rev/462f792e609d
https://hg.mozilla.org/mozilla-central/rev/6c6d07b53773
https://hg.mozilla.org/mozilla-central/rev/1a7da96bca66
https://hg.mozilla.org/mozilla-central/rev/70d5de256f8b
https://hg.mozilla.org/mozilla-central/rev/16b7d6a72288
https://hg.mozilla.org/mozilla-central/rev/cc9e3394bf4f
https://hg.mozilla.org/mozilla-central/rev/37f859f3252e
https://hg.mozilla.org/mozilla-central/rev/a57b374c5f80
https://hg.mozilla.org/mozilla-central/rev/9e31e7bd21c0

Comment 46

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1416209aafe6
Implement --duration/-d command line option. r=jonco
https://hg.mozilla.org/integration/autoland/rev/c83d1d35e4cd
Adjust garbagePerFrame to around 50% 60fps frame drops on my laptop r=jonco
https://hg.mozilla.org/integration/autoland/rev/bf6efd095484
Split out a sequencer object. r=jonco
https://hg.mozilla.org/integration/autoland/rev/e192ac723df1
Replace LoadCycle sequencer with a more general ChainSequencer. r=jonco
https://hg.mozilla.org/integration/autoland/rev/a94d86a69ec8
Use mutator objects instead of names (minor refactor). r=jonco
https://hg.mozilla.org/integration/autoland/rev/dac4bcdd1a5b
Eliminate events in favor of pushing start/end control down into sequencers. r=jonco

Comment 47

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/1416209aafe6
https://hg.mozilla.org/mozilla-central/rev/c83d1d35e4cd
https://hg.mozilla.org/mozilla-central/rev/bf6efd095484
https://hg.mozilla.org/mozilla-central/rev/e192ac723df1
https://hg.mozilla.org/mozilla-central/rev/a94d86a69ec8
https://hg.mozilla.org/mozilla-central/rev/dac4bcdd1a5b

Comment 48

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9920987a04bc
Implement a Find50Sequencer that searches for the garbagePerFrame resulting in 50% frame drop at 60fps r=jonco

Comment 49

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/9920987a04bc

Comment 50

[Alexandru Ionescu (needinfo me) [:alexandrui]]

== Change summary for alert #26355 (as of Fri, 26 Jun 2020 18:41:49 GMT) ==

Improvements:

10% tabpaint windows10-64-shippable-qr opt e10s stylo 45.17 -> 40.77

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=26355

Comment 51

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:sfink, maybe it's time to close this bug?

Comment 52

[Steve Fink [:sfink] [:s:]]

Everything I've implemented so far has landed. Clearing leave-open.