Closed
Bug 1633696
Opened 4 years ago
Closed 4 years ago
Rename isVariableInUse to getVariableValue
Categories
(DevTools :: Inspector: Rules, task, P3)
DevTools
Inspector: Rules
Tracking
(firefox78 fixed)
RESOLVED
FIXED
Firefox 78
| Tracking | Status | |
|---|---|---|
| firefox78 | --- | fixed |
People
(Reporter: rcaliman, Assigned: joseagnesria, Mentored)
Details
(Keywords: good-first-bug)
Attachments
(1 file)
The OutputParser's option isVariableInUse is not returning a Boolean as its name would imply, but the CSS Variable's value, if found.
The method name should be renamed throughout the DevTools code base.
|
Reporter | |
Updated•4 years ago
|
Priority: -- → P3
|
|
Reporter | |
Updated•4 years ago
|
Type: enhancement → task
|
|
Reporter | |
Updated•4 years ago
|
Mentor: rcaliman
Keywords: good-first-bug
|
||
Comment 1•4 years ago
|
||
Hi there. This would be my first experience with open source. Can I take up this issue?
|
Assignee | |
Comment 2•4 years ago
|
||
Hi, I would like to tackle this problem. Can you assign this bug to me? This would be my first contribution.
|
||
Updated•4 years ago
|
Assignee: nobody → joseagnesria
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 3•4 years ago
|
||
Pushed by rcaliman@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/066e3f696262 Rename isVariableInUse to getVariableValue. r=rcaliman
|
|
Reporter | |
Comment 5•4 years ago
|
||
Thanks for working on this, Ria Agnes Jose! The patch looks good.
There's been a misunderstanding here. jugaljoshi96 had asked first to work on this. It would be nice to reply to the original request before assigning work on a bug. We'll take more care in the future. Apologies for this, jugaljoshi96.
|
||
Comment 6•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox78:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 78
You need to log in
before you can comment on or make changes to this bug.
Description
•