1633696 - Rename isVariableInUse to getVariableValue

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, task, P3)

Description

[Razvan Caliman [:rcaliman]]

The OutputParser's option isVariableInUse is not returning a Boolean as its name would imply, but the CSS Variable's value, if found.

The method name should be renamed throughout the DevTools code base.

Comment 1

[jugaljoshi96]

Hi there. This would be my first experience with open source. Can I take up this issue?

Comment 2

[Ria Agnes Jose]

Hi, I would like to tackle this problem. Can you assign this bug to me? This would be my first contribution.

Comment 3

[Ria Agnes Jose]

Attachment: Bug 1633696 - Rename isVariableInUse to getVariableValue. r=rcaliman,gl

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/066e3f696262
Rename isVariableInUse to getVariableValue. r=rcaliman

Comment 5

[Razvan Caliman [:rcaliman]]

Thanks for working on this, Ria Agnes Jose! The patch looks good.

There's been a misunderstanding here. jugaljoshi96 had asked first to work on this. It would be nice to reply to the original request before assigning work on a bug. We'll take more care in the future. Apologies for this, jugaljoshi96.

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/066e3f696262