Open Bug 1633710 Opened 5 years ago Updated 4 months ago

Replace nsIPrincipal.uri functions with new Principal counterparts in js

Categories

(Core :: DOM: Security, task, P2)

Product:
Core
Component:
DOM: Security
Type:
task

Tracking

()

Status:
REOPENED
Milestone:
mozilla78
Tracking Flags:
Tracking Status
firefox78 --- affected

People

(Reporter: sstreich, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: leave-open, Whiteboard: [domsecurity-active])

Attachments

(7 files, 18 obsolete files)

Bug 1633710 - Move js uri.AsciiHost to principal r=ckerschb
47 bytes, text/x-phabricator-request
Details | Review
Bug 1633710 - Move js uri.hostPort to principal r=ckerschb
47 bytes, text/x-phabricator-request
Details | Review
Bug 1633710 - Move js uri.schemeIs to principal r=ckerschb
47 bytes, text/x-phabricator-request
Details | Review
Bug 1633710 - Move js uri.host to principal r=ckerschb
47 bytes, text/x-phabricator-request
Details | Review
Bug 1633710 - Move js uri.equals to principal r=ckerschb
47 bytes, text/x-phabricator-request
Details | Review
Bug 1633710 - principal.URI in Sanitizer.jsm r=ckerschb
47 bytes, text/x-phabricator-request
Details | Review
Bug 1633710 - Move uri.spec calls to nsIPrincipal r=ckerschb
47 bytes, text/x-phabricator-request
Details | Review

See Metabug :)

  • As we now have a solid set of functions of uri in principal, so we should move the callees to principal.
Assignee: nobody → sstreich
Status: NEW → ASSIGNED
Priority: -- → P2
Whiteboard: [domsecurity-active]

Depends on D73241

Depends on D73242

Pushed by malexandru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a1339bfb947e Move js uri.hostPort to principal r=ckerschb https://hg.mozilla.org/integration/autoland/rev/5384d06f6664 Move js uri.schemeIs to principal r=ckerschb https://hg.mozilla.org/integration/autoland/rev/e5cf1b1ebf93 Move js uri.equals to principal r=ckerschb

https://hg.mozilla.org/mozilla-central/rev/a1339bfb947e
https://hg.mozilla.org/mozilla-central/rev/5384d06f6664
https://hg.mozilla.org/mozilla-central/rev/e5cf1b1ebf93

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox78: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
Status: RESOLVED → REOPENED
Keywords: leave-open
Resolution: FIXED → ---
Pushed by rmaries@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7c728e75474e Move js uri.AsciiHost to principal r=ckerschb
Pushed by rmaries@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/461c861e1190 principal.URI in Sanitizer.jsm r=ckerschb,johannh

Sorry about that, fixed the issue and updated the patch :)

Flags: needinfo?(sstreich)
Pushed by abutkovits@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/114eee40b1dc principal.URI in Sanitizer.jsm r=ckerschb,johannh
Pushed by dluca@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2c46bcd325bb Move js uri.host to principal r=ckerschb,preferences-reviewers,ntim
Pushed by dluca@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/255d9078dd17 Move js uri.host to principal r=ckerschb,preferences-reviewers,ntim

(In reply to Dorel Luca [:dluca] from comment #19)

Backed out changeset 255d9078dd17 (bug 1633710) for Browser-chrome failures in extensions/test/xpinstall/browser_datauri.js. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=308699486&repo=autoland&lineNumber=15260

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedTaskRun=EfurvauFQJq1GG9frGBLZw.0&revision=255d9078dd17a62ad3933d5a2c7c2976b9267eff

Backout:
https://hg.mozilla.org/integration/autoland/rev/1199564710e0ea0e05643e593c9d29daa343cd3d

fixed the data uri test :)

Flags: needinfo?(sstreich)
Pushed by abutkovits@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/da35c25c966f Move js uri.host to principal r=ckerschb,preferences-reviewers,ntim
Attachment #9162491 - Attachment description: Bug 1633710 - Move Add createContentPrincipal to nsIPrincipal r=ckerschb → Bug 1633710 - Remove createContentPrincipal callers with nsIPrincipal.uri r=ckerschb

Comment on attachment 9162488 [details]
Bug 1633710 - Refactor SiteDataManager.jsm to not use principal.uri r=ckerschb

Revision D82912 was moved to bug 1654583. Setting attachment 9162488 [details] to obsolete.

Attachment #9162488 - Attachment is obsolete: true

Comment on attachment 9162493 [details]
Bug 1633710 - Remove principal.uri in RemotePageAccessManager.jsm r=ckerschb

Revision D82917 was moved to bug 1655945. Setting attachment 9162493 [details] to obsolete.

Attachment #9162493 - Attachment is obsolete: true
Pushed by ncsoregi@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4ed7b13fb7a5 Move uri.spec calls to nsIPrincipal r=necko-reviewers,geckoview-reviewers,preferences-reviewers,ckerschb,ntim,snorp,valentin

Sorry about that, test is green now - :)

Flags: needinfo?(sstreich)
Pushed by cbrindusan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ff5cb90ca89f Move uri.spec calls to nsIPrincipal r=necko-reviewers,geckoview-reviewers,preferences-reviewers,ckerschb,ntim,snorp,valentin
Pushed by abutkovits@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6d39aab86966 Move display-(spec/prepath/host) to nsIPrincipal r=geckoview-reviewers,snorp
Pushed by nbeleuzu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/07e51bfc3436 Replace principal.uri.prepath with principal.prepath r=ckerschb

Comment on attachment 9162495 [details]
Bug 1633710 - Add isLocalIpAdress to nsIPrincipal r=ckerschb

Revision D82919 was moved to bug 1660822. Setting attachment 9162495 [details] to obsolete.

Attachment #9162495 - Attachment is obsolete: true

Comment on attachment 9162494 [details]
Bug 1633710 - Remove principal.uri in BrowserUtils.jsm r=ckerschb

Revision D82918 was moved to bug 1661280. Setting attachment 9162494 [details] to obsolete.

Attachment #9162494 - Attachment is obsolete: true

Comment on attachment 9162507 [details]
Bug 1633710 - Remove principal.uri in e10sutils r=ckerschb

Revision D82931 was moved to bug 1666442. Setting attachment 9162507 [details] to obsolete.

Attachment #9162507 - Attachment is obsolete: true

Comment on attachment 9162491 [details]
Bug 1633710 - Remove createContentPrincipal callers with nsIPrincipal.uri r=ckerschb

Revision D82915 was moved to bug 1667034. Setting attachment 9162491 [details] to obsolete.

Attachment #9162491 - Attachment is obsolete: true

The leave-open keyword is there and there is no activity for 6 months.
:sstreich, maybe it's time to close this bug?

Flags: needinfo?(sstreich)

The leave-open keyword is there and there is no activity for 6 months.
:sstreich, maybe it's time to close this bug?

Flags: needinfo?(sstreich)
Attachment #9162501 - Attachment is obsolete: true
Attachment #9162499 - Attachment is obsolete: true
Attachment #9162502 - Attachment is obsolete: true

The leave-open keyword is there and there is no activity for 6 months.
:sstreich, maybe it's time to close this bug?
For more information, please visit auto_nag documentation.

Flags: needinfo?(sstreich)

The leave-open keyword is there and there is no activity for 6 months.
:sstreich, maybe it's time to close this bug?
For more information, please visit auto_nag documentation.

Flags: needinfo?(sstreich)

Moving back into triage queue.

Assignee: sstreich → nobody
Flags: needinfo?(sstreich)
Assignee: nobody → sstreich
Attachment #9162496 - Attachment is obsolete: true
Attachment #9162498 - Attachment is obsolete: true
Attachment #9162497 - Attachment is obsolete: true
Attachment #9162500 - Attachment is obsolete: true
Attachment #9162505 - Attachment is obsolete: true
Attachment #9162506 - Attachment is obsolete: true
Attachment #9162503 - Attachment is obsolete: true
Attachment #9162492 - Attachment is obsolete: true
Attachment #9162489 - Attachment is obsolete: true
Assignee: sstreich → nobody
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: