1633770 - Unnecessary loop in ContentSearchUIController._updateDefaultEngineIcon

Status: RESOLVED FIXED

(Firefox :: Search, task, P5)

Description

[Mark Banner (:standard8)]

Currently ContentSearchUIController._updateDefaultEngineIcon is iterating through the engines list to find out the identifier of the default engine:

https://searchfox.org/mozilla-central/rev/158bac3df3a1890da55bdb6ffdaf9a7ffc0bfb0a/browser/base/content/contentSearchUI.js#685-687

      let eng = this._engines.find(
        engine => engine.name === this.defaultEngine.name
      );

      let icon =
        eng && eng.identifier ? this.defaultEngine.icon : DEFAULT_INPUT_ICON;

Rather than iterating through the loop, we should simply store the identifier with alongside the name/icon in set defaultEngine(engine), we can then use that rather directly rather than looping through all the engines.

Comment 1

[Jayati Shrivastava]

Hello, May I submit a patch for this? :)

Comment 2

[Mark Banner (:standard8)]

(In reply to Jayati Shrivastava from comment #1)

Hello, May I submit a patch for this? :)

As this is a good first bug, and you've already done a few, could we leave this for a newer contributor? If you're looking for another bug then bug 1624733 is a bit more advanced, and don't forget about your other current assigned bugs as well.

Comment 3

[Jayati Shrivastava]

Attachment: Bug 1633770 - Remove unnecessary loop in ContentSearchUIController._updateDefaultEngineIcon.r=standard8

Comment 4

[Jayati Shrivastava]

Sorry Mark. I missed seeing your comment before submitting the patch. Should I abandon it?

Comment 5

[Mark Banner (:standard8)]

No, that's fine, it is done now.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c9d662b12de5
Remove unnecessary loop in ContentSearchUIController._updateDefaultEngineIcon.r=Standard8

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/c9d662b12de5