1633780 - Permafailing /webrtc/RTCPeerConnection-iceGatheringState.html | setLocalDescription(rollback) of original offer should cause iceGatheringState to reach "new" when starting in "gathering" when Gecko 77 merges to Beta on 2020-05-04

Status: VERIFIED FIXED

(Core :: WebRTC: Signaling, defect, P1)

Description

[Natalia Csoregi [:nataliaCs]]

Central as beta:
https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&selectedTaskRun=dMF7EzMERvSLnqi9AofECA-0&revision=320b9f6939a99f905d228baecc7df280115a0bb6&searchStr=wpt

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=299797888&repo=try&lineNumber=118886

[task 2020-04-28T15:06:24.649Z] 15:06:24 INFO - TEST-PASS | /webrtc/RTCPeerConnection-iceGatheringState.html | Initial iceGatheringState should be new
[task 2020-04-28T15:06:24.649Z] 15:06:24 INFO - TEST-PASS | /webrtc/RTCPeerConnection-iceGatheringState.html | iceGatheringState should eventually become complete after setLocalDescription
[task 2020-04-28T15:06:24.650Z] 15:06:24 INFO - TEST-PASS | /webrtc/RTCPeerConnection-iceGatheringState.html | setLocalDescription(reoffer) with no new transports should not cause iceGatheringState to change
[task 2020-04-28T15:06:24.650Z] 15:06:24 INFO - TEST-PASS | /webrtc/RTCPeerConnection-iceGatheringState.html | rolling back an ICE restart when gathering is complete should not result in iceGatheringState changes
[task 2020-04-28T15:06:24.650Z] 15:06:24 INFO - TEST-PASS | /webrtc/RTCPeerConnection-iceGatheringState.html | setLocalDescription(reoffer) with a new transport should cause iceGatheringState to go to "checking" and then "complete"
[task 2020-04-28T15:06:24.650Z] 15:06:24 INFO - TEST-PASS | /webrtc/RTCPeerConnection-iceGatheringState.html | sRD does not cause ICE gathering state changes
[task 2020-04-28T15:06:24.650Z] 15:06:24 INFO - TEST-PASS | /webrtc/RTCPeerConnection-iceGatheringState.html | setLocalDescription(rollback) of original offer should cause iceGatheringState to reach "new" when starting in "complete"
[task 2020-04-28T15:06:24.650Z] 15:06:24 INFO - TEST-UNEXPECTED-FAIL | /webrtc/RTCPeerConnection-iceGatheringState.html | setLocalDescription(rollback) of original offer should cause iceGatheringState to reach "new" when starting in "gathering" - promise_test: Unhandled rejection with value: object "TypeError: Promise.any is not a function"
[task 2020-04-28T15:06:24.650Z] 15:06:24 INFO - ..
[task 2020-04-28T15:06:24.650Z] 15:06:24 INFO - TEST-OK | /webrtc/RTCPeerConnection-iceGatheringState.html | took 8737ms

Byron can you take a look please?
Thank you.

Comment 1

[Byron Campen [:bwc]]

Ah, Promise.any is only supported in nightly right now. I'm guessing we do not plan to ship for 77?

Comment 2

[André Bargull [:anba]]

We're currently waiting for https://github.com/tc39/proposal-promise-any/issues/38 before shipping Promise.any, so it won't land in time for 77.

Comment 3

[Byron Campen [:bwc]]

Ok, I'll just re-do that with Promise.allSettled.

Comment 4

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e05638b9a64f98eb5ec6b08166dc1381ce8e2c1e

Comment 5

[Cosmin Sabou [:CosminS]]

Byron, the fix from the try push works in today's beta-sim: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&classifiedState=unclassified&author=csabou%40mozilla.com&fromchange=56f7ac5216096e0cedd404ce32f2c2296ffba163&tochange=2eaf4ae7a038df49405ed53f8826aadbf163fa76&searchStr=wpt16&selectedTaskRun=Zmln6TIFQXGx_wSCvhQBkg-0
Could you make a patch and land it on tree after it's reviewed?

Comment 6

[Byron Campen [:bwc]]

Attachment: Bug 1633780: Use Promise.allSettled instead of Promise.any, since the latter is nightly-only right now. r?jib

Comment 7

[Byron Campen [:bwc]]

This one is kinda urgent.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/94917b4ce0d1
Use Promise.allSettled instead of Promise.any, since the latter is nightly-only right now. r=jib

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/23320 for changes under testing/web-platform/tests

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 11

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/94917b4ce0d1

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 13

[Andreea Pavel [:apavel]]

Verified fixed in latest beta sim: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception&revision=bda28e2e932ccbbd5d81bfdaac898786b8265f7a