Permafailing /webrtc/RTCPeerConnection-iceGatheringState.html | setLocalDescription(rollback) of original offer should cause iceGatheringState to reach "new" when starting in "gathering" when Gecko 77 merges to Beta on 2020-05-04
Categories
(Core :: WebRTC: Signaling, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr68 | --- | unaffected |
firefox75 | --- | unaffected |
firefox76 | --- | unaffected |
firefox77 | + | verified |
People
(Reporter: nataliaCs, Assigned: bwc)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=299797888&repo=try&lineNumber=118886
[task 2020-04-28T15:06:24.649Z] 15:06:24 INFO - TEST-PASS | /webrtc/RTCPeerConnection-iceGatheringState.html | Initial iceGatheringState should be new
[task 2020-04-28T15:06:24.649Z] 15:06:24 INFO - TEST-PASS | /webrtc/RTCPeerConnection-iceGatheringState.html | iceGatheringState should eventually become complete after setLocalDescription
[task 2020-04-28T15:06:24.650Z] 15:06:24 INFO - TEST-PASS | /webrtc/RTCPeerConnection-iceGatheringState.html | setLocalDescription(reoffer) with no new transports should not cause iceGatheringState to change
[task 2020-04-28T15:06:24.650Z] 15:06:24 INFO - TEST-PASS | /webrtc/RTCPeerConnection-iceGatheringState.html | rolling back an ICE restart when gathering is complete should not result in iceGatheringState changes
[task 2020-04-28T15:06:24.650Z] 15:06:24 INFO - TEST-PASS | /webrtc/RTCPeerConnection-iceGatheringState.html | setLocalDescription(reoffer) with a new transport should cause iceGatheringState to go to "checking" and then "complete"
[task 2020-04-28T15:06:24.650Z] 15:06:24 INFO - TEST-PASS | /webrtc/RTCPeerConnection-iceGatheringState.html | sRD does not cause ICE gathering state changes
[task 2020-04-28T15:06:24.650Z] 15:06:24 INFO - TEST-PASS | /webrtc/RTCPeerConnection-iceGatheringState.html | setLocalDescription(rollback) of original offer should cause iceGatheringState to reach "new" when starting in "complete"
[task 2020-04-28T15:06:24.650Z] 15:06:24 INFO - TEST-UNEXPECTED-FAIL | /webrtc/RTCPeerConnection-iceGatheringState.html | setLocalDescription(rollback) of original offer should cause iceGatheringState to reach "new" when starting in "gathering" - promise_test: Unhandled rejection with value: object "TypeError: Promise.any is not a function"
[task 2020-04-28T15:06:24.650Z] 15:06:24 INFO - ..
[task 2020-04-28T15:06:24.650Z] 15:06:24 INFO - TEST-OK | /webrtc/RTCPeerConnection-iceGatheringState.html | took 8737ms
Byron can you take a look please?
Thank you.
Assignee | ||
Comment 1•4 years ago
|
||
Ah, Promise.any is only supported in nightly right now. I'm guessing we do not plan to ship for 77?
Assignee | ||
Updated•4 years ago
|
Comment 2•4 years ago
|
||
We're currently waiting for https://github.com/tc39/proposal-promise-any/issues/38 before shipping Promise.any
, so it won't land in time for 77.
Assignee | ||
Comment 3•4 years ago
|
||
Ok, I'll just re-do that with Promise.allSettled.
Assignee | ||
Comment 4•4 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e05638b9a64f98eb5ec6b08166dc1381ce8e2c1e
Updated•4 years ago
|
Comment 5•4 years ago
|
||
Byron, the fix from the try push works in today's beta-sim: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&classifiedState=unclassified&author=csabou%40mozilla.com&fromchange=56f7ac5216096e0cedd404ce32f2c2296ffba163&tochange=2eaf4ae7a038df49405ed53f8826aadbf163fa76&searchStr=wpt16&selectedTaskRun=Zmln6TIFQXGx_wSCvhQBkg-0
Could you make a patch and land it on tree after it's reviewed?
Assignee | ||
Comment 6•4 years ago
|
||
Assignee | ||
Comment 7•4 years ago
|
||
This one is kinda urgent.
Updated•4 years ago
|
Pushed by bcampen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/94917b4ce0d1 Use Promise.allSettled instead of Promise.any, since the latter is nightly-only right now. r=jib
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/23320 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
Comment 11•4 years ago
|
||
bugherder |
Upstream PR merged by moz-wptsync-bot
Comment 13•4 years ago
|
||
Verified fixed in latest beta sim: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception&revision=bda28e2e932ccbbd5d81bfdaac898786b8265f7a
Updated•4 years ago
|
Updated•4 years ago
|
Description
•