1633868 - [wpt-sync] Sync PR 23305 - bluetooth: Improve fake device setup helpers

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 23305 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23305
Details from upstream follow.

Ovidio Henriquez <[e-mail]> wrote:

bluetooth: Improve fake device setup helpers

This change adds a more versatile fake device setup helper. This helper
can add services and set the device as connectable and with all services
discovered. Additionally, the device can be requested with the given
RequestDeviceOptions.

This change also adds a global fakeCentral object that enables test to
be able to use it to simulate advertisements or to be able to add more
fake devices mid-test.

This change converts the Blocklist and HID fake helpers. The
Health Thermometer helpers require more work to properly convert to using
the new method, so it will be done in a future patch.

Bug: 1070816
Change-Id: I7ff70949e9ff7b22cc1a4e0ac235a42ea7356018
Reviewed-on: https://chromium-review.googlesource.com/2165446
WPT-Export-Revision: 09377f2a8012fb6e3f7a12a98df5040182199139

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 23305 applied with additional changes from upstream: 6f8f0b30a4af91762427b4ff528ed344d5636c6d, ed5724f22f115f3d70b7b053abc106b6fae7a0c6

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=45b430a2115be873152292ff21bdfcbd94411952

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Notable wpt changes

# CI Results

Ran 6 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 232 tests

## Status Summary

### Firefox
OK     : 153
PASS   : 67
FAIL   : 154
TIMEOUT: 12
ERROR  : 12

### Chrome
OK     : 165
PASS   : 2
FAIL   : 164

### Safari
OK     : 153
FAIL   : 154
TIMEOUT: 12
ERROR  : 12

## Links
[Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=45b430a2115be873152292ff21bdfcbd94411952)
[GitHub PR Head](https://wpt.fyi/results/?sha=f3f45b4d57251225e7fc61fb0805f44a05fcc824&label=pr_head)
[GitHub PR Base](https://wpt.fyi/results/?sha=f3f45b4d57251225e7fc61fb0805f44a05fcc824&label=pr_base)

## Details

(See attachment for full changes)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/818305611ebe
[wpt PR 23305] - bluetooth: Improve fake device setup helpers, a=testonly

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d1a87c32ce0
[wpt PR 23305] - bluetooth: Improve fake device setup helpers, a=testonly

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/7d1a87c32ce0