1633964 - Cleanup FunctionData::atom

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P2)

Description

[Ted Campbell [:tcampbell]]

There is some confusion with the stencil frontend work about explicitName() vs other atoms. I'd like to get it into a consistent state before we make this more complex by updating the NameResolver

Comment 1

[Ted Campbell [:tcampbell]]

Attachment: Bug 1633964 - Use explicitName() when creating BinAST FunctionBox. r?mgaudet

The name in the FunctionBox should only hold the explicitName rather than any
sort of implicit or guessed name. Note that any other names still on the
function itself will remain set. This seems to be a minor regression
recently, but only in BinAST.

Comment 2

[Ted Campbell [:tcampbell]]

Attachment: Bug 1633964 - Rename FunctionCreationData::atom to explicitName. r?mgaudet

This is a bit of a lateral change but brings consistency with the
FunctionBox. In the future we will fold proper guessed-atom support into
FunctionBox to allow the NameResolver to work without JSFunctions.

Depends on D72997

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6ef176eab485
Use explicitName() when creating BinAST FunctionBox. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/4cffe6e1c9a9
Rename FunctionCreationData::atom to explicitName. r=mgaudet

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/6ef176eab485
https://hg.mozilla.org/mozilla-central/rev/4cffe6e1c9a9