Closed Bug 1633997 Opened 5 years ago Closed 5 years ago

Remove no longer used functionality from M(Load|Store)UnboxedScalar and M(Load|Store)Element

Tracking

()

Status:

RESOLVED FIXED

Milestone:

mozilla77

Tracking Flags:

Tracking

Status

firefox77

---

fixed

People

(Reporter: anba, Assigned: anba)

Details

Attachments

(4 files)

Bug 1633997 - Part 1: Remove canonicalize-doubles flag from MLoadUnboxedScalar. r=jandem! 5 years ago André Bargull [:anba] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1633997 - Part 2: Remove IsValidElementsType function. r=jandem! 5 years ago André Bargull [:anba] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1633997 - Part 3: Remove offsetAdjustement from MLoadElement, MStoreElement, and MStoreUnboxedScalar. r=jandem! 5 years ago André Bargull [:anba] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1633997 - Part 4: Remove MLoadUnboxedScalar::readType. r=jandem! 5 years ago André Bargull [:anba] 47 bytes, text/x-phabricator-request		Details \| Review

André Bargull [:anba]

Assignee

Description

•

5 years ago

MLoadUnboxedScalar::canonicalizeDoubles() always returns true.
IsValidElementsType is always called with elements->type() == MIRType::Elements.
MLoadElement, MStoreElement, and MStoreUnboxedScalar have a offsetAdjustment_ field which is always 0.
MLoadUnboxedScalar::readType_ is always equal to MLoadUnboxedScalar::storageType_.

André Bargull [:anba]

Assignee

Comment 1

•

5 years ago

Attached file Bug 1633997 - Part 1: Remove canonicalize-doubles flag from MLoadUnboxedScalar. r=jandem! — Details

André Bargull [:anba]

Assignee

Comment 2

•

5 years ago

Attached file Bug 1633997 - Part 2: Remove IsValidElementsType function. r=jandem! — Details

Depends on D73018

André Bargull [:anba]

Assignee

Comment 3

•

5 years ago

Attached file Bug 1633997 - Part 3: Remove offsetAdjustement from MLoadElement, MStoreElement, and MStoreUnboxedScalar. r=jandem! — Details

Depends on D73019

André Bargull [:anba]

Assignee

Comment 4

•

5 years ago

Attached file Bug 1633997 - Part 4: Remove MLoadUnboxedScalar::readType. r=jandem! — Details

Depends on D73020

Steven DeTar [:sdetar]

Updated

•

5 years ago

Priority: -- → P2

Pulsebot

Comment 5

•

5 years ago

Pushed by dluca@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7e735f5f7240 Part 1: Remove canonicalize-doubles flag from MLoadUnboxedScalar. r=jandem https://hg.mozilla.org/integration/autoland/rev/8ab35749a947 Part 2: Remove IsValidElementsType function. r=jandem https://hg.mozilla.org/integration/autoland/rev/cbe3434e60db Part 3: Remove offsetAdjustement from MLoadElement, MStoreElement, and MStoreUnboxedScalar. r=jandem https://hg.mozilla.org/integration/autoland/rev/f9c7506b95af Part 4: Remove MLoadUnboxedScalar::readType. r=jandem

Daniel Varga [:dvarga]

Comment 6

•

5 years ago

•

Edited

Backed out 4 changesets (Bug 1633997) for causing gtest failures at ImageDecoders.AVIFSingleChunk

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=S-yXTfe9SUSNFRxH9BqyTw-0&revision=f9c7506b95af0b3cb46688a5761368b8ce411ecf

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=300139976&repo=autoland&lineNumber=24854

Backout link: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=S-yXTfe9SUSNFRxH9BqyTw-0&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=70b07be891e077c6c997e026ec1181a721210759

[task 2020-04-30T03:52:45.885Z] 03:52:45     INFO -  TEST-START | ImageDecoders.AVIFSingleChunk
[task 2020-04-30T03:52:45.885Z] 03:52:45  WARNING -  TEST-UNEXPECTED-FAIL | ImageDecoders.AVIFSingleChunk | Expected equality of these values:
[task 2020-04-30T03:52:45.885Z] 03:52:45     INFO -    pmColor.mBlue
[task 2020-04-30T03:52:45.885Z] 03:52:45     INFO -      Which is: '\x5' (5)
[task 2020-04-30T03:52:45.885Z] 03:52:45     INFO -    gotColor.mBlue
[task 2020-04-30T03:52:45.885Z] 03:52:45     INFO -      Which is: '\0' @ /builds/worker/checkouts/gecko/image/test/gtest/Common.cpp:207
[task 2020-04-30T03:52:45.886Z] 03:52:45  WARNING -  TEST-UNEXPECTED-FAIL | ImageDecoders.AVIFSingleChunk | Expected equality of these values:
[task 2020-04-30T03:52:45.886Z] 03:52:45     INFO -    pmColor.mRed
[task 2020-04-30T03:52:45.886Z] 03:52:45     INFO -      Which is: '.' (46, 0x2E)
[task 2020-04-30T03:52:45.886Z] 03:52:45     INFO -    gotColor.mRed
[task 2020-04-30T03:52:45.886Z] 03:52:45     INFO -      Which is: '\0' @ /builds/worker/checkouts/gecko/image/test/gtest/Common.cpp:209
[task 2020-04-30T03:52:45.886Z] 03:52:45  WARNING -  TEST-UNEXPECTED-FAIL | ImageDecoders.AVIFSingleChunk | Expected equality of these values:
[task 2020-04-30T03:52:45.886Z] 03:52:45     INFO -    expectedPixel
[task 2020-04-30T03:52:45.886Z] 03:52:45     INFO -      Which is: 4281270021
[task 2020-04-30T03:52:45.886Z] 03:52:45     INFO -    gotPixel
[task 2020-04-30T03:52:45.886Z] 03:52:45     INFO -      Which is: 4278255360 @ /builds/worker/checkouts/gecko/image/test/gtest/Common.cpp:211
[task 2020-04-30T03:52:45.886Z] 03:52:45  WARNING -  TEST-UNEXPECTED-FAIL | ImageDecoders.AVIFSingleChunk | Value of: IsSolidColor(surface, aTestCase.Color(), aTestCase.Fuzz())
[task 2020-04-30T03:52:45.887Z] 03:52:45     INFO -    Actual: false
[task 2020-04-30T03:52:45.887Z] 03:52:45     INFO -  Expected: true @ /builds/worker/checkouts/gecko/image/test/gtest/TestDecoders.cpp:89
[task 2020-04-30T03:52:45.887Z] 03:52:45  WARNING -  TEST-UNEXPECTED-FAIL | ImageDecoders.AVIFSingleChunk | test completed (time: 3ms)
[task 2020-04-30T03:52:45.887Z] 03:52:45     INFO -  TEST-START | ImageDecoders.AVIFDelayedChunk
[task 2020-04-30T03:52:45.887Z] 03:52:45  WARNING -  TEST-UNEXPECTED-FAIL | ImageDecoders.AVIFDelayedChunk | Expected equality of these values:
[task 2020-04-30T03:52:45.887Z] 03:52:45     INFO -    pmColor.mBlue
[task 2020-04-30T03:52:45.887Z] 03:52:45     INFO -      Which is: '\x5' (5)
[task 2020-04-30T03:52:45.887Z] 03:52:45     INFO -    gotColor.mBlue
[task 2020-04-30T03:52:45.887Z] 03:52:45     INFO -      Which is: '\0' @ /builds/worker/checkouts/gecko/image/test/gtest/Common.cpp:207
[task 2020-04-30T03:52:45.887Z] 03:52:45  WARNING -  TEST-UNEXPECTED-FAIL | ImageDecoders.AVIFDelayedChunk | Expected equality of these values:
[task 2020-04-30T03:52:45.887Z] 03:52:45     INFO -    pmColor.mRed
[task 2020-04-30T03:52:45.888Z] 03:52:45     INFO -      Which is: '.' (46, 0x2E)
[task 2020-04-30T03:52:45.888Z] 03:52:45     INFO -    gotColor.mRed
[task 2020-04-30T03:52:45.888Z] 03:52:45     INFO -      Which is: '\0' @ /builds/worker/checkouts/gecko/image/test/gtest/Common.cpp:209
[task 2020-04-30T03:52:45.888Z] 03:52:45  WARNING -  TEST-UNEXPECTED-FAIL | ImageDecoders.AVIFDelayedChunk | Expected equality of these values:
[task 2020-04-30T03:52:45.888Z] 03:52:45     INFO -    expectedPixel
[task 2020-04-30T03:52:45.888Z] 03:52:45     INFO -      Which is: 4281270021
[task 2020-04-30T03:52:45.888Z] 03:52:45     INFO -    gotPixel
[task 2020-04-30T03:52:45.888Z] 03:52:45     INFO -      Which is: 4278255360 @ /builds/worker/checkouts/gecko/image/test/gtest/Common.cpp:211
[task 2020-04-30T03:52:45.888Z] 03:52:45  WARNING -  TEST-UNEXPECTED-FAIL | ImageDecoders.AVIFDelayedChunk | Value of: IsSolidColor(surface, aTestCase.Color(), aTestCase.Fuzz())
[task 2020-04-30T03:52:45.888Z] 03:52:45     INFO -    Actual: false
[task 2020-04-30T03:52:45.889Z] 03:52:45     INFO -  Expected: true @ /builds/worker/checkouts/gecko/image/test/gtest/TestDecoders.cpp:89
[task 2020-04-30T03:52:45.889Z] 03:52:45  WARNING -  TEST-UNEXPECTED-FAIL | ImageDecoders.AVIFDelayedChunk | test completed (time: 4ms)
[task 2020-04-30T03:52:45.889Z] 03:52:45     INFO -  TEST-START | ImageDecoders.AVIFMultiChunk
[task 2020-04-30T03:52:45.915Z] 03:52:45  WARNING -  TEST-UNEXPECTED-FAIL | ImageDecoders.AVIFMultiChunk | Expected equality of these values:
[task 2020-04-30T03:52:45.915Z] 03:52:45     INFO -    pmColor.mBlue
[task 2020-04-30T03:52:45.915Z] 03:52:45     INFO -      Which is: '\x5' (5)
[task 2020-04-30T03:52:45.915Z] 03:52:45     INFO -    gotColor.mBlue
[task 2020-04-30T03:52:45.915Z] 03:52:45     INFO -      Which is: '\0' @ /builds/worker/checkouts/gecko/image/test/gtest/Common.cpp:207
[task 2020-04-30T03:52:45.915Z] 03:52:45  WARNING -  TEST-UNEXPECTED-FAIL | ImageDecoders.AVIFMultiChunk | Expected equality of these values:
[task 2020-04-30T03:52:45.916Z] 03:52:45     INFO -    pmColor.mRed
[task 2020-04-30T03:52:45.916Z] 03:52:45     INFO -      Which is: '.' (46, 0x2E)
[task 2020-04-30T03:52:45.916Z] 03:52:45     INFO -    gotColor.mRed
[task 2020-04-30T03:52:45.916Z] 03:52:45     INFO -      Which is: '\0' @ /builds/worker/checkouts/gecko/image/test/gtest/Common.cpp:209
[task 2020-04-30T03:52:45.916Z] 03:52:45  WARNING -  TEST-UNEXPECTED-FAIL | ImageDecoders.AVIFMultiChunk | Expected equality of these values:
[task 2020-04-30T03:52:45.916Z] 03:52:45     INFO -    expectedPixel
[task 2020-04-30T03:52:45.916Z] 03:52:45     INFO -      Which is: 4281270021
[task 2020-04-30T03:52:45.916Z] 03:52:45     INFO -    gotPixel
[task 2020-04-30T03:52:45.916Z] 03:52:45     INFO -      Which is: 4278255360 @ /builds/worker/checkouts/gecko/image/test/gtest/Common.cpp:211
[task 2020-04-30T03:52:45.916Z] 03:52:45  WARNING -  TEST-UNEXPECTED-FAIL | ImageDecoders.AVIFMultiChunk | Value of: IsSolidColor(surface, aTestCase.Color(), aTestCase.Fuzz())
[task 2020-04-30T03:52:45.916Z] 03:52:45     INFO -    Actual: false
[task 2020-04-30T03:52:45.917Z] 03:52:45     INFO -  Expected: true @ /builds/worker/checkouts/gecko/image/test/gtest/TestDecoders.cpp:89
[task 2020-04-30T03:52:45.917Z] 03:52:45  WARNING -  TEST-UNEXPECTED-FAIL | ImageDecoders.AVIFMultiChunk | test completed (time: 31ms)
[task 2020-04-30T03:52:45.917Z] 03:52:45     INFO -  TEST-START | ImageDecoders.AVIFLargeMultiChunk
[task 2020-04-30T03:52:46.048Z] 03:52:46     INFO -  TEST-PASS | ImageDecoders.AVIFLargeMultiChunk | test completed (time: 143ms)
[task 2020-04-30T03:52:46.048Z] 03:52:46     INFO -  TEST-START | ImageDecoders.AVIFDownscaleDuringDecode
[task 2020-04-30T03:52:46.048Z] 03:52:46     INFO -  TEST-PASS | ImageDecoders.AVIFDownscaleDuringDecode | test completed (time: 3ms)
[task 2020-04-30T03:52:46.049Z] 03:52:46     INFO -  TEST-START | ImageDecoders.AnimatedGIFSingleChunk
[task 2020-04-30T03:52:46.049Z] 03:52:46     INFO -  TEST-PASS | ImageDecoders.AnimatedGIFSingleChunk | test completed (time: 1ms)
[task 2020-04-30T03:52:46.050Z] 03:52:46     INFO -  TEST-START | ImageDecoders.AnimatedGIFMultiChunk
[task 2020-04-30T03:52:46.094Z] 03:52:46     INFO -  TEST-PASS | ImageDecoders.AnimatedGIFMultiChunk | test completed (time: 17ms)
[task 2020-04-30T03:52:46.094Z] 03:52:46     INFO -  TEST-START | ImageDecoders.AnimatedGIFWithBlendedFrames
[task 2020-04-30T03:52:46.094Z] 03:52:46     INFO -  TEST-PASS | ImageDecoders.AnimatedGIFWithBlendedFrames | test completed (time: 0ms)
[task 2020-04-30T03:52:46.095Z] 03:52:46     INFO -  TEST-START | ImageDecoders.AnimatedPNGSingleChunk
[task 2020-04-30T03:52:46.095Z] 03:52:46     INFO -  TEST-PASS | ImageDecoders.AnimatedPNGSingleChunk | test completed (time: 1ms)
[task 2020-04-30T03:52:46.095Z] 03:52:46     INFO -  TEST-START | ImageDecoders.AnimatedPNGMultiChunk
[task 2020-04-30T03:52:46.095Z] 03:52:46     INFO -  TEST-PASS | ImageDecoders.AnimatedPNGMultiChunk | test completed (time: 18ms)
[task 2020-04-30T03:52:46.095Z] 03:52:46     INFO -  TEST-START | ImageDecoders.AnimatedPNGWithBlendedFrames
[task 2020-04-30T03:52:46.095Z] 03:52:46     INFO -  TEST-PASS | ImageDecoders.AnimatedPNGWithBlendedFrames | test completed (time: 0ms)
[task 2020-04-30T03:52:46.096Z] 03:52:46     INFO -  TEST-START | ImageDecoders.AnimatedWebPSingleChunk
[task 2020-04-30T03:52:46.096Z] 03:52:46     INFO -  TEST-PASS | ImageDecoders.AnimatedWebPSingleChunk | test completed (time: 1ms)
[task 2020-04-30T03:52:46.096Z] 03:52:46     INFO -  TEST-START | ImageDecoders.AnimatedWebPMultiChunk
[task 2020-04-30T03:52:46.096Z] 03:52:46     INFO -  TEST-PASS | ImageDecoders.AnimatedWebPMultiChunk | test completed (time: 8ms)
[task 2020-04-30T03:52:46.096Z] 03:52:46     INFO -  TEST-START | ImageDecoders.AnimatedWebPWithBlendedFrames
[task 2020-04-30T03:52:46.096Z] 03:52:46     INFO -  TEST-PASS | ImageDecoders.AnimatedWebPWithBlendedFrames | test completed (time: 0ms)
[task 2020-04-30T03:52:46.096Z] 03:52:46     INFO -  TEST-START | ImageDecoders.CorruptSingleChunk
[task 2020-04-30T03:52:46.096Z] 03:52:46     INFO -  Corrupt JPEG data: 1865 extraneous bytes before marker 0xd9
[task 2020-04-30T03:52:46.096Z] 03:52:46     INFO -  JPEG decoding error:
[task 2020-04-30T03:52:46.096Z] 03:52:46     INFO -  Invalid JPEG file structure: missing SOS marker

Flags: needinfo?(andrebargull)

Pulsebot

Comment 7

•

5 years ago

Pushed by rmaries@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0f96a8d65a33 Part 1: Remove canonicalize-doubles flag from MLoadUnboxedScalar. r=jandem https://hg.mozilla.org/integration/autoland/rev/188fafc8d931 Part 2: Remove IsValidElementsType function. r=jandem https://hg.mozilla.org/integration/autoland/rev/b8ee08581434 Part 3: Remove offsetAdjustement from MLoadElement, MStoreElement, and MStoreUnboxedScalar. r=jandem https://hg.mozilla.org/integration/autoland/rev/a9fa5e82905c Part 4: Remove MLoadUnboxedScalar::readType. r=jandem

Razvan Maries

Comment 8

•

5 years ago

Relanded: https://hg.mozilla.org/integration/autoland/rev/83beb87d9f6945ccddefe62341b5536398eb72a0

Flags: needinfo?(andrebargull)

Andreea Pavel [:apavel]

Comment 9

•

5 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/0f96a8d65a33
https://hg.mozilla.org/mozilla-central/rev/188fafc8d931
https://hg.mozilla.org/mozilla-central/rev/b8ee08581434
https://hg.mozilla.org/mozilla-central/rev/a9fa5e82905c

Status: ASSIGNED → RESOLVED

Closed: 5 years ago

status-firefox77: affected → fixed

Resolution: --- → FIXED

Target Milestone: --- → mozilla77

You need to log in before you can comment on or make changes to this bug.

Bugzilla

Remove no longer used functionality from M(Load|Store)UnboxedScalar and M(Load|Store)Element

Categories

(Core :: JavaScript Engine: JIT, task, P2)

Tracking

()

People

(Reporter: anba, Assigned: anba)

References

Details

Crash Data

Security

(public)

User Story

Attachments

(4 files)

Description

Comment 1

Comment 2

Comment 3

Comment 4

Updated

Comment 5

Comment 6

Comment 7

Comment 8

Comment 9

Attachment

General

Description

File Name

Content Type