1634029 - Reorganize observer modules and simplify watching for created/closed browser windows

Status: RESOLVED FIXED

(Remote Protocol :: Agent, task, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

Before I want to start working on bug 1593226 I would like to see this refactoring landed, which makes the code easier to understand and follow.

Here the notable proposed changes:

• Move all observer modules into the /remote/observers folder
• Simplify handling of XUL/DOMWindows, and remove the extra not-needed WindowObserver
• Rename TabTarget to PageTarget and TabSession to PageSession to align with CDP

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

Attachment: Bug 1634029 - [remote] Re-organize observer modules into a single directory.

To better keep track of available observer classes
it's better to have them all in the same folder.

While moving files around the patch also renames
the TabObserver module to TargetObserver, which
would allow us to add target observers for workers
in the future.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

Attachment: Bug 1634029 - [remote] Simplify handling of created DOMWindow's.

The changes align our code to other instances of nsIWindowMediatorListener
usage in-tree, which always rely on the "load" event. Also "interactive"
isn't a ready state a XULWindow can ever be in, it's only used for content
windows.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

Attachment: Bug 1634029 - [remote] Integrate WindowObserver into TabObserver.

The WindowObserver class is only used by the TabObserver, and as such
can easily be integrated transparently. This also removes the extra
events as being emitted for opening and closing XUL windows.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

Attachment: Bug 1634029 - [remote] Adjust naming for page target to align with CDP.

Within CDP there is no tab target, but a page target. The patch
renames our TabTarget class appropriately for an easier understanding
of our code.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

Attachment: Bug 1634029 - [remote] Adjust naming for page sessions to align with CDP.

Within CDP there is no tab session, but a page session. The patch
renames our TabSession class appropriately for an easier understanding
of our code.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/804e863ee8d0
[remote] Re-organize observer modules into a single directory. r=remote-protocol-reviewers,maja_zf
https://hg.mozilla.org/integration/autoland/rev/1da9a1cbc272
[remote] Simplify handling of created DOMWindow's. r=remote-protocol-reviewers,maja_zf
https://hg.mozilla.org/integration/autoland/rev/2ea167bead02
[remote] Integrate WindowObserver into TabObserver. r=remote-protocol-reviewers,maja_zf

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/804e863ee8d0
https://hg.mozilla.org/mozilla-central/rev/1da9a1cbc272
https://hg.mozilla.org/mozilla-central/rev/2ea167bead02