Closed Bug 1634046 Opened 1 year ago Closed 1 year ago

Create browser-associated popups/panels for autoscroll / date-input / form-validation on an as-needed basis

Categories

(Firefox :: Tabbed Browser, task, P3)

task

Tracking

()

RESOLVED FIXED
Firefox 79
Tracking Status
firefox79 --- fixed

People

(Reporter: Gijs, Assigned: emalysz)

References

(Blocks 1 open bug)

Details

(Keywords: perf, Whiteboard: [fxperf:p2])

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1634031 +++

The implementations of autoscroll, <input type=date>, and form validation all use panel/popup nodes. We should create them on an as-needed basis, instead of hardcoding them in browser.xhtml markup, to help avoid paying startup costs for items that are likely to be unused in a lot of sessions.

This should be reasonably straightforward - thankfully, it doesn't look like any of the C++ code directly tries to talk to these elements, so it's all down to actors and the tabbrowser implementation that hooks up these elements/attributes.

Severity: -- → N/A
Priority: -- → P3
Keywords: perf

I guess this applies to bug 1634031 as well - before we give this an fxperf priority though, how easy would it be to test the impact of this and bug 1634031 on startup by making a patch which just removes these things entirely? I assume that the primary goal of this would be to improve warm startup times? In which case talos should do a reasonable job at measuring the impact.

(In reply to Doug Thayer [:dthayer] from comment #1)

I guess this applies to bug 1634031 as well - before we give this an fxperf priority though, how easy would it be to test the impact of this and bug 1634031 on startup by making a patch which just removes these things entirely? I assume that the primary goal of this would be to improve warm startup times? In which case talos should do a reasonable job at measuring the impact.

Does bug 1624683 comment 1 answer your question? :-)

Flags: needinfo?(dothayer)

It does!

Flags: needinfo?(dothayer)
Whiteboard: [fxperf] → [fxperf:p2]
Assignee: nobody → emalysz
Attachment #9150158 - Attachment description: Bug 1634046: lazy load invalid form panel by placing in template → Bug 1634046: lazy load invalid form, date/time picker, and autoscroll panels and popups by placing in templates.
Pushed by btara@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1585337fe15c
lazy load invalid form, date/time picker, and autoscroll panels and popups by placing in templates. r=Gijs
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 79
You need to log in before you can comment on or make changes to this bug.