1634046 - Create browser-associated popups/panels for autoscroll / date-input / form-validation on an as-needed basis

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, task, P3)

Description

[:Gijs (he/him)]

+++ This bug was initially created as a clone of Bug #1634031 +++

The implementations of autoscroll, <input type=date>, and form validation all use panel/popup nodes. We should create them on an as-needed basis, instead of hardcoding them in browser.xhtml markup, to help avoid paying startup costs for items that are likely to be unused in a lot of sessions.

This should be reasonably straightforward - thankfully, it doesn't look like any of the C++ code directly tries to talk to these elements, so it's all down to actors and the tabbrowser implementation that hooks up these elements/attributes.

Comment 1

[Alex Thayer [:alexical] (she/her)]

I guess this applies to bug 1634031 as well - before we give this an fxperf priority though, how easy would it be to test the impact of this and bug 1634031 on startup by making a patch which just removes these things entirely? I assume that the primary goal of this would be to improve warm startup times? In which case talos should do a reasonable job at measuring the impact.

Comment 2

[:Gijs (he/him)]

(In reply to Doug Thayer [:dthayer] from comment #1)

I guess this applies to bug 1634031 as well - before we give this an fxperf priority though, how easy would it be to test the impact of this and bug 1634031 on startup by making a patch which just removes these things entirely? I assume that the primary goal of this would be to improve warm startup times? In which case talos should do a reasonable job at measuring the impact.

Does bug 1624683 comment 1 answer your question? :-)

Comment 3

[Alex Thayer [:alexical] (she/her)]

It does!

Comment 4

[Emma Malysz]

Attachment: Bug 1634046: lazy load invalid form, date/time picker, and autoscroll panels and popups by placing in templates.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1585337fe15c
lazy load invalid form, date/time picker, and autoscroll panels and popups by placing in templates. r=Gijs

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/1585337fe15c