1634122 - INI linter won't allow the same key name in different sections

Status: RESOLVED INVALID

(Developer Infrastructure :: Lint and Formatting, defect, P3)

Description

[Robin Steuber (she/her) [:bytesized]]

STR:

1. Create this file in the tree at this path: browser/locales/en-US/test.ini:

[Section1]
Key1=String1

[Section2]
Key1=String1

2. Run ./mach lint browser/locales/en-US/test.ini

Expected Results:

Linter will emit no errors

Actual results:

c:/mozilla-central-secondary/browser/locales/en-US/test.ini
  2:1  error  Duplicate string with ID: Key1  (l10n)
  5:1  error  Duplicate string with ID: Key1  (l10n)

✖ 2 problems (2 errors, 0 warnings)

Comment 1

[Robin Steuber (she/her) [:bytesized]]

As the triage owner, do you think this bug might be fixed soon? I have a patch that needs to be merged soonish, and I'm trying to figure out whether I ought to wait for this to be fixed, or restructure my localization INI to avoid this bug.

Comment 2

[Andrew Halberstadt [:ahal]]

Redirecting to Axel. You should be able to add an exclusion to your file in tools/lint/l10n.yml as well.

Comment 3

[Axel Hecht [:Pike]]

The linter works as expected, our support for INI files in the l10n toolchain is at "whatever crashreporter needed at the time".

As the linter is right, resolving this as INVALID.

I'll add more detail in bug 1621700.