1634245 - Protection level in Protection UI remains in English

Status: RESOLVED INVALID

(Firefox :: Protections UI, defect)

Description

[Francesco Lodolo [:flod]]

Attachment: Screenshot

We recently migrated the panel to Fluent in bug 1609559, but I think the issue is caused by bug 1587870, which originally introduced the label.
https://hg.mozilla.org/mozilla-central/rev/26fe0b14808f

Looks like we're setting an attribute label, when we should set the value?

<label xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul" id="protections-popup-footer-protection-type-label" data-l10n-id="protections-popup-footer-protection-label-custom" label="Personalizzata">Custom</label>

Comment 1

[Francesco Lodolo [:flod]]

[Tracking Requested - why for this release]: untranslated content in the Protection UI.

Comment 2

[Pascal Chevrel:pascalc]

Attachment: not seeing bug in French build

I am not seeing this bug in the latest nightly (neither in yesterday's)
Mozilla/5.0 (X11; Linux x86_64; rv:77.0) Gecko/20100101 Firefox/77.0 ID:20200429215539

Comment 3

[Francesco Lodolo [:flod]]

Thanks. You're absolutely right, the fault is mine. The ID is long enough that I missed the value, and only translated the label, so it only affects Italian.