1634304 - [Dynamic FPI] TEST-UNEXPECTED-FAIL | browser/components/sessionstore/test/browser_sessionStorage.js

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, defect, P2)

Description

[Gary Chen [:xeonchen]]

Set network.cookie.cookieBehavior=5 as default value.

TEST-UNEXPECTED-FAIL | browser/components/sessionstore/test/browser_sessionStorage.js | Uncaught exception - at chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_sessionStorage.js:30 - TypeError: can't access property "test", storage['http://example.com'] is undefined

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=299273199&repo=try&lineNumber=3071

Comment 1

[Gary Chen [:xeonchen]]

Attachment: Bug 1634304 - Part 1: use storage principal in session store;

Comment 2

[Gary Chen [:xeonchen]]

Attachment: Bug 1634304 - Part 2: disable inner check for restored tab;

Depends on D73474

Comment 3

[Gary Chen [:xeonchen]]

Attachment: Bug 1634304 - Part 3: remove specific prefs setting;

Depends on D71941, D73475

Comment 4

[Gary Chen [:xeonchen]]

leave open until we land part 3.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb6ec4639231
Part 1: use storage principal in session store; r=baku
https://hg.mozilla.org/integration/autoland/rev/ad0f593251ee
Part 2: disable inner check for restored tab; r=baku

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/bb6ec4639231
https://hg.mozilla.org/mozilla-central/rev/ad0f593251ee

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4101036168d4
Part 3: remove specific prefs setting; r=baku

Comment 8

[Noemi Erli[:noemi_erli]]

Backed out changeset 4101036168d4 (Bug 1634304) for causing failures in browser_sessionStorage.js CLOSED TREE

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedTaskRun=fqpI9BFwTcOnX5-5MAACfA.0&resultStatus=testfailed%2Cbusted%2Cexception&revision=4101036168d4aaf3dba618c724dfde42980b7cd2

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=307443152&repo=autoland&lineNumber=38922

Backout: https://hg.mozilla.org/integration/autoland/rev/58cce4cc179a1285a1feeee64e0ec154821c9f16