1634357 - 2dcontext/wide-gamut-canvas/canvas-colorManaged-convertToBlob-roundtrip.html is marked as timeout

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, task, P3)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

I am looking at all the web-platform-tests that are marked as timeout and I found:
2dcontext/wide-gamut-canvas/canvas-colorManaged-convertToBlob-roundtrip.html

this is timeout because of:
srcCanvas.convertToBlob is not a function

In addition I see this on another test which is marked as fail:
2dcontext/wide-gamut-canvas/canvas-createImageBitmap-e_srgb.html

I would like to determine if we support convertToBlob on a canvas:

1. supported (and we need to fix the tests)
2. not [fully] supported, but on a roadmap in the next year (run the tests as 'backlog' on m-c only)
3. no plans to support this (stop running the tests altogether)

Comment 1

[Timothy Nikkel (:tnikkel)]

convertToBlob looks like a function of offscreen canvas. Which I believe is currently preffed off in firefox.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

is there a pref? We could set that pref for these tests and they could run successfully.

Comment 3

[Timothy Nikkel (:tnikkel)]

Looks like there is gfx.offscreencanvas.enabled

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

I tried this locally (windows 10) and didn't change the failure to find convertToBlob.

Comment 5

[Timothy Nikkel (:tnikkel)]

I just looked, there is no code in our tree to implement convertToBlob.

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

thanks for looking- I couldn't find any bug with convertToBlob specifics, there are 2 choices I see here:

1. mark these 2 tests as not-implementing (no plans to support and implement convertToBlob)
2. mark these 2 tests as backlog (plans to support and implement in the next year)

I am happy to go either route, or if there is a 3rd route.

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: Bug 1634357 - move convertToBlob tests to backlog (tier-2). r=tnikkel

move convertToBlob tests to backlog (tier-2).

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

:jgilbert - for convertToBlob, support, I would like to know:

1. is this something that will be implemented/supported in the next year - we should run this as tier-2 on mozilla-central only
2. are there no plans to support this - we will not run these tests at all

Comment 9

[Kelsey Gilbert [:jgilbert]]

We expect to support this within the next year.
We should also fix that test to not time out. It should instead fail quickly, and we should mark it as an expected failure.

Comment 10

[Joel Maher ( :jmaher ) (UTC -8)]

:jgilbert, can you assign this to someone as I am not familiar with the test or what it should be doing?

Comment 11

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: Bug 1634357 - move convertToBlob tests to backlog (tier-2). r=jgilbert

move convertToBlob tests to backlog (tier-2).

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2fc539be19f5
move convertToBlob tests to backlog (tier-2). r=jgilbert

Comment 13

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/2fc539be19f5