16344 - File op: Crash when attempting to fileRename a known file to ""

Status: VERIFIED FIXED

(Core Graveyard :: Installer: XPInstall Engine, defect, P3)

Description

[Jimmy Lee]

Build: 10/12/99 SeaMonkey build

1. From http://jimbob/trigger2.html, trigger
   http://jimbob/jars/f_fileop_filerename_blank.xpi

jarSrc3 = "smrtupdt.txt";

startInstall("Functional: f_fileop_filerename_blank",
"f_fileop_filerename_blank", "1.1.1.1", 0);
f = getFolder("Program", "filerename_other");
addFile("fileop_filerename_blank", "2.2.2.2", jarSrc3, f, jarSrc3, true);
fileSource3 = f + jarSrc3;
fileTarget3 = "";
err3 = fileRename(fileSource3, fileTarget3);
logComment("Path to fileSource3 = " + fileSource3);
logComment("fileRename returns = " + err3);

RESULT:
Crash.  The text file does not get added to the directory.  There is no log
information from Install.log.  All platforms crash.

TalkBack Incident ID = 14230394

 Call Stack:    (Signature = DeleteEntry b5ebec43)
      DeleteEntry
[d:\builds\seamonkey\mozilla\xpinstall\src\nsInstall.cpp, line 2063]
   _hashEnumerate
[d:\builds\seamonkey\mozilla\xpcom\ds\nsHashtable.cpp, line 86]
   PL_HashTableEnumerateEntries
[plhash.c, line 369]
   nsHashtable::Enumerate
[d:\builds\seamonkey\mozilla\xpcom\ds\nsHashtable.cpp, line 215]
   0x004d9920

EXPECTED RESULT:
No Crash.  Error message returned or file does not get renamed.

Comment 1

[Sean Su]

it no longer crashes, and should return an error value instead.

Comment 2

[Jimmy Lee]

Build 1999-10-18-09-M11(WIN), 1999-10-18-12-M11(MAC), 1999-10-18-08-M11(LINUX)

Excellent!

Comment 3

[leger]

Bulk move of XPInstall (component to be deleted) bugs to Installer: XPInstall
Engine