Color of container indicator in tab bar does not update when changing it
Categories
(Firefox :: Tabbed Browser, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox78 | --- | fixed |
People
(Reporter: mail, Assigned: Gijs)
References
(Blocks 1 open bug, Regression)
Details
(Keywords: regression)
Attachments
(3 files)
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:76.0) Gecko/20100101 Firefox/76.0
Steps to reproduce:
Using multi-account containers, open a tab in any container, then go to your settings and change the color for that container
Actual results:
The colored bar in the tab indicating what container is used did not update until reopening the tab
(it is unknown if this behaviour is avoided by closing any tab or closing all tabs of a container)
Expected results:
The colored bar in the tab indicating what container is used should change color to reflect the new setting
|
Reporter | |
Comment 1•4 years ago
|
||
Demonstration of the bug
|
||
Comment 2•4 years ago
|
||
Bugbug thinks this bug should belong to this component, but please revert this change in case of error.
|
|
Reporter | |
Comment 3•4 years ago
|
||
(In reply to Anselm Schüler from comment #0)
(it is unknown if this behaviour is avoided by closing any tab or closing all tabs of a container)
It is. See attached video.
|
||
Updated•4 years ago
|
|
Assignee | |
Comment 4•4 years ago
|
||
Is this a regression? ISTR this used to work, but I could well be wrong...
|
|
||
Comment 5•4 years ago
|
||
I think this is not a regression. I can reproduce the issue on Nightly66.0a1(20190128092811) Windows10.
|
|
Reporter | |
Comment 6•4 years ago
|
||
demonstration-of-other-situation
|
|
Reporter | |
Comment 7•4 years ago
|
||
Tab color does update on the tab the settings page is in. See uploaded video.
|
|
Reporter | |
Comment 8•4 years ago
|
||
(In reply to Anselm Schüler from comment #7)
Tab color does update on the tab the settings page is in. See uploaded video.
This does not invalidate this issue
|
|
Assignee | |
Comment 9•4 years ago
|
||
There's code to do this but the code is just horribly broken.
|
|
Assignee | |
Comment 10•4 years ago
|
||
Looks like bug 1344519 changed the observer notification but didn't update the tabbrowser consumer, and there were no tests.
|
||
Updated•4 years ago
|
|
|
Assignee | |
Comment 11•4 years ago
|
||
|
||
Comment 12•4 years ago
|
||
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/d2032ecd7540 actually update tab colours when container data changes, r=dao
|
||
Comment 13•4 years ago
|
||
| bugherder | ||
Description
•