1634432 - Can't open Error object rendered in customFormat in sidebar

Status: RESOLVED FIXED

(DevTools :: Console, defect, P2)

Description

[Nicolas Chevobbe [:nchevobbe]]

Steps to reproduce

1. Open the console
2. Evaluate new Error("bloup")
3. Right click on the error

Expected results

I can click on the Open in sidebar context menu item

Actual results

I can't

---

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1634432 - Enable inspecting error object in sidebar. r=bomsy.

To enable the Open In Sidebar action, we were retrieving the
actor id of the root node of an object inspector.
But in the case of error, we don't use the object inspector
to render them, only the reps.
We still have a reference to the actor id though, so when
there's no object inspector, but that we have an actor id
ref, we enable the action.
A test case is added in a mochitest to ensure this works as
expected for an error object, and that we can observe custom
properties that are not displayed in the error rep.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/280adf94b62d
Enable inspecting error object in sidebar. r=bomsy.

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/280adf94b62d