Closed Bug 1634432 Opened 2 months ago Closed 2 months ago

Can't open Error object rendered in customFormat in sidebar

Categories

(DevTools :: Console, defect, P2)

defect

Tracking

(firefox78 fixed)

RESOLVED FIXED
Firefox 78
Tracking Status
firefox78 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Steps to reproduce

  1. Open the console
  2. Evaluate new Error("bloup")
  3. Right click on the error

Expected results

I can click on the Open in sidebar context menu item

Actual results

I can't


To enable the Open In Sidebar action, we were retrieving the
actor id of the root node of an object inspector.
But in the case of error, we don't use the object inspector
to render them, only the reps.
We still have a reference to the actor id though, so when
there's no object inspector, but that we have an actor id
ref, we enable the action.
A test case is added in a mochitest to ensure this works as
expected for an error object, and that we can observe custom
properties that are not displayed in the error rep.

Severity: -- → S4
Attachment #9144748 - Attachment description: Bug 1634432 - Enable inspecting error object in sidebar. r=jlast. → Bug 1634432 - Enable inspecting error object in sidebar. r=bomsy.
Attachment #9144748 - Attachment description: Bug 1634432 - Enable inspecting error object in sidebar. r=bomsy. → Bug 1634432 - Enable inspecting error object in sidebar. r=jlast.
Attachment #9144748 - Attachment description: Bug 1634432 - Enable inspecting error object in sidebar. r=jlast. → Bug 1634432 - Enable inspecting error object in sidebar. r=bomsy.
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/280adf94b62d
Enable inspecting error object in sidebar. r=bomsy.
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 78
You need to log in before you can comment on or make changes to this bug.