1634435 - Remove some AutoGCRooter kinds

Status: RESOLVED FIXED

(Core :: JavaScript: GC, task, P3)

Description

[Jon Coppeard (:jonco)]

We can remove some AutoGCRooter kinds, either by using Rooted or making them use CustomAutoRooter where this makes sense.

Ideally we'd remove AutoGCRooter entirely and use Rooted for everything, but it's used for wrapper rooters which are a special case and CustomAutoRooter which is used by DOM bindings.

Comment 2

[Jon Coppeard (:jonco)]

Attachment: Bug 1634435 - Replace AutoValueArray and AutoArrayRooter implementations with Rooted<> r?jandem

We can make these kinds use the existing Rooted infrastructure.

Depends on D73292

Comment 3

[Jon Coppeard (:jonco)]

Attachment: Bug 1634435 - Rename AutoValueArray to RootedValueArray everywhere for consistency with other rooted things r?jandem,mccr8

Depends on D73293

Comment 4

[Jon Coppeard (:jonco)]

Attachment: Bug 1634435 - Rename AutoArrayRooter to RootedExternalValueArray r?jandem

Rename this to RootedSomething for consistency. Let me know if you have a better idea for the name. It's a bit unwieldy but it's only used in a couple of places.

Depends on D73295

Comment 5

[Jon Coppeard (:jonco)]

Attachment: Bug 1634435 - Remove parser auto rooters r?sfink

Since the parsers have a virtual trace method already we can handle these by making them CustomAutoRooters and get rid of the special kinds.

Depends on D73296

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/468d51ba84c7
Replace AutoValueArray and AutoArrayRooter implementations with Rooted<> r=jandem
https://hg.mozilla.org/integration/autoland/rev/2d04df2a8065
Rename AutoValueArray to RootedValueArray everywhere for consistency with other rooted things r=jandem,mccr8
https://hg.mozilla.org/integration/autoland/rev/20f7c76d9f35
Rename AutoArrayRooter to RootedExternalValueArray r=jandem
https://hg.mozilla.org/integration/autoland/rev/e4aadc2d4945
Remove parser auto rooters r=sfink

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/468d51ba84c7
https://hg.mozilla.org/mozilla-central/rev/2d04df2a8065
https://hg.mozilla.org/mozilla-central/rev/20f7c76d9f35
https://hg.mozilla.org/mozilla-central/rev/e4aadc2d4945