1634447 - Allow SWGL shaders to run both with and without perspective

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, task, P1)

Description

[Lee Salzman [:lsalzman]]

Based on ideas discussed to solve bug 1633912, this patch implements allowing each shader to switch between no-perspective and perspective on per-primitive based on whether or not the primitive's W coordinates all match. This should be a sufficient stop-gap for now to unblock testing and development. Performance and memory usage costs of this approach will need to be evaluated before we decide whether to keep it long term.

Comment 1

[Lee Salzman [:lsalzman]]

Attachment: Bug 1634447 - allow SWGL shaders to work with and without perspective. r?jrmuizel

Comment 2

[Lee Salzman [:lsalzman]]

Attachment: Bug 1634447 - don't generate perspective code if SWGL fragment shader doesn't use it. r?jrmuizel

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2d29da387d9e
allow SWGL shaders to work with and without perspective. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/2f81714ca3e3
don't generate perspective code if SWGL fragment shader doesn't use it. r=jrmuizel

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/2d29da387d9e
https://hg.mozilla.org/mozilla-central/rev/2f81714ca3e3