Closed Bug 1634447 Opened 3 months ago Closed 3 months ago

Allow SWGL shaders to run both with and without perspective

Categories

(Core :: Graphics: WebRender, task, P1)

task

Tracking

()

RESOLVED FIXED
mozilla77
Tracking Status
firefox77 --- fixed

People

(Reporter: lsalzman, Assigned: lsalzman)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Based on ideas discussed to solve bug 1633912, this patch implements allowing each shader to switch between no-perspective and perspective on per-primitive based on whether or not the primitive's W coordinates all match. This should be a sufficient stop-gap for now to unblock testing and development. Performance and memory usage costs of this approach will need to be evaluated before we decide whether to keep it long term.

Blocks: 1634452
Pushed by lsalzman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2d29da387d9e
allow SWGL shaders to work with and without perspective. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/2f81714ca3e3
don't generate perspective code if SWGL fragment shader doesn't use it. r=jrmuizel
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in before you can comment on or make changes to this bug.