1634543 - contenteditable element with ::after pseudoelement (with content) is collapsed

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Mike Taylor [:miketaylr]]

Attachment: imgflip.html

STR:

1. load https://imgflip.com/ai-meme

Expected: the "[optional] prefix text e.g. Eric" text fits in its containing contenteditable div
Actual: it doesn't. Compare to Chrome.

In the TC, there's a gray bg in Chrome, but no visible bg in Firefox.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1634543 - Make emptiness check for contenteditable also account for empty frames. r=jfkthame

Like abspos and other out of flows. Seems to match more what other browsers do.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1634543 - Fix caret baseline of a block with only empty lines. r=jfkthame

Even with the fix above, we get the caret baseline wrong because the
line is non-empty, but the baseline is all the way to the top.

Maybe an alternative to this would be to move the line-height hack to
the beginning of layout but that sounds a bit more fishy.

Otherwise we should do this more often, I suspect. I added one test that
fails because of nsInlineFrame... Anyhow probably follow-up material?

Depends on D73362

Comment 3

[Emilio Cobos Álvarez [:emilio]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=275a20c415457262fae752d4a12e99b48ea74b93

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b97ab5796dec
Make emptiness check for contenteditable also account for empty frames. r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/a38299795286
Fix caret baseline of a block with only empty lines. r=jfkthame

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dac68a1f3d81
Followup: Remove one too many consts to unbust the build.

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/23370 for changes under testing/web-platform/tests

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/b97ab5796dec
https://hg.mozilla.org/mozilla-central/rev/a38299795286
https://hg.mozilla.org/mozilla-central/rev/dac68a1f3d81