1634569 - window.open() windows created from a mousedown handler immediately lose focus

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Mike Taylor [:miketaylr]]

I'm not sure where this should live, so please move to the right place!

STR:

1. visit https://miketaylr.com/bzla/vega.html
2. click on "mousedown" to open a new window/tab
3. allow the popup, and click again

Expected:
The new tab is focused (it says via mousedown)

Actual:
The new tab opens, then focus jumps back to the original tab

Note: mouseup and click result in expected behavior.

I discovered this while investigating a library which uses mousedown to open new windows, https://github.com/vega/vega-embed/blob/ed326f48996dbb3c3fb8f0a4517f0523afa123be/src/embed.ts#L390-L402

Comment 1

[Alice0775 White]

I can reproduce the issue on Nightly77.0a1 Winmdows10.

Regression Window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=ebb28cae3bc2c3249af72d85893a6e0913e4c5fc&tochange=d12917561f27e4c4b4808707b55e88973dc4a385

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Hrrmmm... Will take a look, over to the queue.

Thanks for finding the regression range Alice, you rock.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

So this is basically because of this chunk of code.

I suspect this is to change the focused window on click, but it doesn't really make sense if you're in different tabs or what not... But maybe even then we don't want to do it and we want to rely on the OS? Hmpf.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

This seems to come from bug 618907, which seems to be a hack-around code that went away in bug 1595435.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Iframe focus switching test.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1634569 - Remove hackaround for bug that can no longer happen. r=masayuki

This seems to come from bug 618907, which seems to be a hack-around code
that went away in bug 1595435.

If we open a window on mousedown such as it gains focus before this code
runs, we just steal the focus from it, which is undesired.

Also remove the test for bug 799299. It doesn't work anyways if the
browser is remote (this test only runs on non-e10s mode), and this
unifies the behavior with e10s and with content (see attached test-case,
which doesn't change behavior with and without my patch).

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6cc9a20bbb57
Remove hackaround for bug that can no longer happen. r=masayuki

Comment 8

[Narcis Beleuzu [:NarcisB]]

Backed out for mochitest failures on test_focus.xhtml

Backout link: https://hg.mozilla.org/integration/autoland/rev/9b05570242cbddc9743b5236c2e5872d8c71876d
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=301006293&repo=autoland&lineNumber=109346

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/26aee5b1821f
Remove hackaround for bug that can no longer happen. r=masayuki

Comment 10

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/26aee5b1821f

Comment 11

[Pascal Chevrel:pascalc]

We have this bug since 69 and no priority set so I guess the fix can ship with 78.