Closed Bug 16346 Opened 25 years ago Closed 24 years ago

iframe: "overflow:hidden" not working

Categories

(Core :: Layout, defect, P2)

Product:
Core
Component:
Layout
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Future

People

(Reporter: slamm, Assigned: pollmann)

References

Details

(Keywords: css2, Whiteboard: [rtm++][nsbeta3-]fix in hand (reviewed, super-reviewed))

Attachments

(2 files)

Patch for IFRAME to honor Overflow style
641 bytes, patch
Details | Diff | Splinter Review
test case
98 bytes, text/html
Details
I would like to have an iframe without scrollbars. Here's what I tried, <iframe src="http://www.mozilla.org/" style="overflow:hidden;"> I am doing the wrong thing, or is this a real bug?
Assignee: kipp → pavlov
Ramiro said that this linux only. Reassigning to pavlov. Ramiro also said that this will go away when we switch to gfx scrollbars.
Assignee: pavlov → troy
Blocks: 8034
Severity: normal → critical
Priority: P3 → P1
Summary: iframe overflow styles not working → iframe: "overflow:hidden" not working
I see this on windows too. Reassigning to component owner. Bumping up priority. The "overflow:hidden" style is ignored for both native and gfx scrollbars.
Assignee: troy → pollmann
Status: NEW → ASSIGNED
Likely this is a dup of bug 14827
No longer blocks: 8034
This bug probably has the same cause as bug 14827 (iframes ignore scrolling="no"), it is just a slightly different code path to verify. Leaving it up to pollmann to make it a dup. Also note, Sidebar is no longer dependant on the feature.
Testing out the fix I posted to bug 14827 to see if it fixes this bug...
Hey, cool - this bug has 6 votes - though they came from only 2 people... :)
Depends on: 14827
Target Milestone: M13
Marking M13 as fixing bug 14827 should fix this, and bug 14827 is M13. Noting dependency on 14827.
Target Milestone: M13 → M14
Bug 14827 was moved to M14, so moving this there too...
Fixing this is a more complex change then for bug 14827 and is not as widespread of a problem. I'm moving this off to M15.
OS: Linux → All
Hardware: PC → All
Target Milestone: M14 → M15
Moving out to M17.
Target Milestone: M15 → M17
Lowering priority, as this is not critical in relation to some of my other bugs. 1) major regressions 2) development blockers 3) crashers and major usability issues 4) cosmetic issues and standards compliance issues This falls in category 4. Moving off to M18.
Severity: critical → normal
Target Milestone: M17 → M18
Nominating nsbeta3. Suggest [nsbeta3+].
Keywords: css2, nsbeta3
As per meeting with ChrisD today, taking QA.
QA Contact: petersen → py8ieh=bugzilla
Marking nsbeta3-. Isn't it overflow:clip not overflow hidden?
Whiteboard: [nsbeta3-]
Looks like only attributes and not style were being looked at in nsHTMLFrameInnerFrame::GetScrolling
Moving bug marked nsbeta3- to Future milestone.
Target Milestone: M18 → Future
Peter has attached a patch to this bug: can you check it and reevaluate the status?
Whiteboard: [nsbeta3-]
This patch looks great - r=pollmann. I just tried it on my FreeBSD build and it works like a charm. I also think that this is a very low risk fix to go into beta3 - renominating since it is now "fix in hand"
Whiteboard: fix in hand
Marking nsbeta3-
Whiteboard: fix in hand → [nsbeta3-]fix in hand
trivial fix, nice find. Extremely low risk, enables much better support for IFrame's and CSS2 property that we already support everywhere else. I'd recommend this for FCS due to extremely low risk. a=buster if you can get PDT to approve.
Removing nsbeta3- for reconsideration. This nsbeta3 bug has a fix, a review and a super-review, and is a near zero risk way to improve standards suporrt - could PDT please read the above comments and attach an assesment? Thanks!
Whiteboard: [nsbeta3-]fix in hand → fix in hand (reviewed, super-reviewed)
Eric, who is your manager?
Kevin: + or -? It has a review and a fix and super-review and everything...
If -, check it into the trunk, please.
Marking nsbeta3+ P2, based on simple, lowrisk fix.
Priority: P1 → P2
Whiteboard: fix in hand (reviewed, super-reviewed) → [nsbeta3+]fix in hand (reviewed, super-reviewed)
Not holding PR3 for this, so marking nsbeta3-. PR3 fixes at this point need to be both super-safe and fixing really bad bugs. Adding rtm nomination so we can apply the patch to the branch after PR3.
Keywords: rtm
Marking nsbeta3- to match Phil's comment.
Whiteboard: [nsbeta3+]fix in hand (reviewed, super-reviewed) → [nsbeta3-]fix in hand (reviewed, super-reviewed)
Marking rtm+.
Whiteboard: [nsbeta3-]fix in hand (reviewed, super-reviewed) → [rtm+][nsbeta3-]fix in hand (reviewed, super-reviewed)
PDT marking [rtm++]
Whiteboard: [rtm+][nsbeta3-]fix in hand (reviewed, super-reviewed) → [rtm++][nsbeta3-]fix in hand (reviewed, super-reviewed)
Fix checked in. (Sorry it took so long to get this patch in!)
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Attached file test case —
To verify, view the above test case in a build that contains the fix. The iframe should not have any scrollbars. Thanks! (And thanks Peter for the fix!)
Keywords: vtrunk
Verified Fixed on trunk builds Testcase has no scrollbars linux 101808 RedHat 6.2 win32 101804 NT 4 mac 101804 Mac OS9 Setting bug to Verified and removing vtrunk keyword
Status: RESOLVED → VERIFIED
Keywords: vtrunk
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: