1634602 - exempt about:blank from privacy.resistFingerprinting (prefers-color-scheme)

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Thorin [:thorin]]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

Bug 1408122 lets ui.systemUsesDarkTheme = 1 use a dark about:blank, however, RFP overrides this and it is white

Tor Ticket: https://trac.torproject.org/projects/tor/ticket/30812#comment:5

Comment 1

[Thorin [:thorin]]

pinging Tom for the RFP part, and the other Tom for the original patch :)

Comment 2

[Tom S [:evilpie]]

Sure should be relatively easy to fix. We just have to decide in which function we will actually check for RFP.

Comment 3

[Tom Ritter [:tjr]]

Attachment: Bug 1634602 - Exempt about:black from color scheme preference in RFP mode r?emilio

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b26c0b538a75
Exempt about:black from color scheme preference in RFP mode r=emilio

Comment 5

[Hiroyuki Ikezoe (:hiro)]

s/about:black/about:blank/ in the commit message...

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/b26c0b538a75

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1634602 - Minor follow-up cleanups.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/34bf1c8f8d60
Minor follow-up cleanups.

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/34bf1c8f8d60

Comment 10

[Thorin [:thorin]]

Can we backport to 78 so ESR-will-have (for Tor Browser)?

Comment 11

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9153459 [details]
Bug 1634602 - Exempt about:black from color scheme preference in RFP mode r?emilio

Beta/Release Uplift Approval Request

• User impact if declined: Tor browser or users of the privacy.resistFingerprinting pref won't get bug 1408122.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple exception for resist-fingerprinting in a non-web-exposed place.
• String changes made/needed: none

Comment 12

[Julien Cristau [:jcristau]]

Comment on attachment 9153459 [details]
Bug 1634602 - Exempt about:black from color scheme preference in RFP mode r?emilio

approved for 78.0b3

Comment 13

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/307b75879bca
https://hg.mozilla.org/releases/mozilla-beta/rev/d6fc47eb7f3b