Closed Bug 1634602 Opened 2 months ago Closed 1 month ago

exempt about:blank from privacy.resistFingerprinting (prefers-color-scheme)

Categories

(Core :: DOM: Core & HTML, enhancement)

77 Branch
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla79
Tracking Status
firefox78 --- fixed
firefox79 --- fixed

People

(Reporter: simon.mainey, Assigned: tjr)

References

(Blocks 1 open bug)

Details

(Whiteboard: [tor 30812])

Attachments

(2 files)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

Bug 1408122 lets ui.systemUsesDarkTheme = 1 use a dark about:blank, however, RFP overrides this and it is white

Tor Ticket: https://trac.torproject.org/projects/tor/ticket/30812#comment:5

Component: Untriaged → DOM: Core & HTML
Product: Firefox → Core
Version: 75 Branch → 77 Branch

pinging Tom for the RFP part, and the other Tom for the original patch :)

Flags: needinfo?(tom)
Flags: needinfo?(evilpies)
Depends on: 1408122
Flags: needinfo?(evilpies)

Sure should be relatively easy to fix. We just have to decide in which function we will actually check for RFP.

No longer depends on: 1408122
Depends on: 1408122
Whiteboard: [tor 30812]
Assignee: nobody → tom
Pushed by tritter@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b26c0b538a75
Exempt about:black from color scheme preference in RFP mode r=emilio

s/about:black/about:blank/ in the commit message...

Status: UNCONFIRMED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79

Can we backport to 78 so ESR-will-have (for Tor Browser)?

Flags: needinfo?(emilio)

Comment on attachment 9153459 [details]
Bug 1634602 - Exempt about:black from color scheme preference in RFP mode r?emilio

Beta/Release Uplift Approval Request

  • User impact if declined: Tor browser or users of the privacy.resistFingerprinting pref won't get bug 1408122.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Simple exception for resist-fingerprinting in a non-web-exposed place.
  • String changes made/needed: none
Flags: needinfo?(emilio)
Attachment #9153459 - Flags: approval-mozilla-beta?

Comment on attachment 9153459 [details]
Bug 1634602 - Exempt about:black from color scheme preference in RFP mode r?emilio

approved for 78.0b3

Flags: needinfo?(tom)
Attachment #9153459 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #9153776 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Blocks: 1588548
You need to log in before you can comment on or make changes to this bug.