Closed Bug 1634611 Opened 3 months ago Closed 3 months ago

[wpt-sync] Sync PR 23354 - Fugu: Add a permission for Screen Enumeration & Window Placement

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox78 fixed)

RESOLVED FIXED
mozilla78
Tracking Status
firefox78 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(Depends on 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 23354 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23354
Details from upstream follow.

Mike Wasserman <msw@chromium.org> wrote:

Fugu: Add a permission for Screen Enumeration & Window Placement

Add WINDOW_PLACEMENT content setting and permission enum values.
Add UX&Privacy-chosen strings, sha hashes for translation screenshots.
Add UX-chosen icon: go/icons#icon=select_window&search=select_window
Scrub icon: jakearchibald.github.io/svgomg + evanstade.github.io/skiafy

Wire up settings page, page info toggle, permission request dialog.

Make ScreenEnumerationImpl a member of RenderFrameHostImpl.
(to support requesting permission for a given host and its origin)

Test michaelwasserman.github.io/window-placement-demo with:
chrome://flags#enable-experimental-web-platform-features OR
$ chrome --enable-experimental-web-platform-features

TODO: Gate remaining feature functionality on this setting
TODO: Plumb user gesture signal for the permission request?
TODO: Reject promise (with kNotAllowedError DOMException) on failure?
TODO: Cache the ScreenEnumeration backend connection in blink?

Bug: 994889, 897300
Test: Window Placement setting and permissions work for getScreens().
Change-Id: Iac38133c966d20d9a04c80d999091df16f9fd5c6
Reviewed-on: https://chromium-review.googlesource.com/2173342
WPT-Export-Revision: f70b260ef41b9ba10dd17f574455e7c7a92f6ad5

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 72 tests

Status Summary

Firefox

OK : 1
PASS : 71
FAIL : 3

Chrome

ERROR: 1

Safari

OK : 1
FAIL : 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/screen_enumeration/getScreens.tentative.https.window.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: ERROR, Safari: OK)
self.getScreens is present: FAIL (Safari: FAIL)
self.getScreens returns at least 1 Screen with permission granted: FAIL (Safari: FAIL)
self.getScreens returns no Screen objects with permission denied: FAIL (Safari: FAIL)

Tests Disabled in Gecko Infrastructure

/screen_enumeration/getScreens.tentative.https.window.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: ERROR, Safari: OK)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3558d6cb07cb
[wpt PR 23354] - Fugu: Add a permission for Screen Enumeration & Window Placement, a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2445588003cd
[wpt PR 23354] - Fugu: Add a permission for Screen Enumeration & Window Placement, a=testonly
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.