1634623 - Don't pass js configure flags to old-configure

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1634623 - Collect js configure arguments separately from old configure arguments.

js subconfigure used to be invoked from old-configure, and the
transition out of old-configure preserved the code sharing.

prepare_configure_options currently collects all the old configure
arguments, separating js_option arguments from js_option environment
variables. This distinction is necessary for old configure, but not
for python configure, so we can now handle all the js_options
similarly.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1634623 - Don't pass js configure flags to old-configure.

As mentioned in previous change, js subconfigure used to be called from
old-configure, and some of that old setup remains to this day.

They don't really cause problems, except speed issues, especially on
Windows: arguments passed to old-configure is treated in a large shell
loop, and the more arguments are passed, the longer it takes. On my
machine, this cumulates to more than 10s! For arguments it doesn't
recognizes and doesn't use. And the environment variable js_options are
not used either, although they don't have a similar impact.

What we're doing here:

• Remove js_options from extra_old_configure_args, that leaves only
  host_for_sub_configure and target_for_sub_configure there.
• Since none of the above are environment variables, we don't need to
  separate out environment variables, nor to pass them down to
  old-configure.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1634623 - Remove add_old_configure_arg/extra_old_configure_args.

Now that there are only two uses of it, and there won't be more, remove
them and just use host_for_sub_configure and target_for_sub_configure
directly.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cb27cbe57e4d
Collect js configure arguments separately from old configure arguments. r=firefox-build-system-reviewers,rstewart
https://hg.mozilla.org/integration/autoland/rev/53f0e4ab7fcf
Don't pass js configure flags to old-configure. r=firefox-build-system-reviewers,rstewart
https://hg.mozilla.org/integration/autoland/rev/fbef9d03ac28
Remove add_old_configure_arg/extra_old_configure_args. r=firefox-build-system-reviewers,rstewart

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/cb27cbe57e4d
https://hg.mozilla.org/mozilla-central/rev/53f0e4ab7fcf
https://hg.mozilla.org/mozilla-central/rev/fbef9d03ac28