1634662 - Search in Inspector doesn't find some elements (rel="icon")

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P2)

Description

[gendalph20]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:75.0) Gecko/20100101 Firefox/75.0

Steps to reproduce:

Inspect any page with a 'link rel="icon"' and any element with a class "icon-whatever" (in this case - some embedded CSS and a span).
Enter search term "icon" (no quotes)
Get completion for ".icon-whatever"

Try searching for rel="icon" and get no completion (fine).
Search doesn't find the <link> element.

Specific page I had issues with is https://privatbank.ua

Actual results:

Any sort of completion overrides whatever search terms user enters on pressing Enter: entering "icon" would complete search term to a CSS class (.icon-whatever), to search for "icon" I have to click somewhere with a mouse, so completion would lose focus and go away.
Moreover, I can't search for rel="icon" - I get no results whatsoever.

Expected results:

User should be allowed to disregard completion using an intuitive hotkey (ideally just Enter and hit Tab to complete, but Ctrl+Enter or Shift+Enter would work too).
In my case, hitting just entering "icon" and hitting Enter should have searched for "icon", and searching for rel="icon" should work.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Razvan Caliman [:rcaliman]]

Autocomplete can be cancelled by pressing the Escape key. Then, it's possible to search using the term typed in the search field.

Searching for "rel" does find the <link> elements. Searching for "rel=" seems to switch the search into a different mode, text search and the <link> elements are no longer found. This is indeed a bug.

Comment 3

[Julian Descottes [:jdescottes]]

The search logic can be found at https://searchfox.org/mozilla-central/rev/dc4560dcaafd79375b9411fdbbaaebb0a59a93ac/devtools/server/actors/utils/walker-search.js#243-299

Note that the inspector search currently allows to search for:

• text content
• attribute names
• attribute values
• xpath
• tagname
• css selector

rel="icon" doesn't match any of the supported search modes.

Comment 4

[gendalph20]

This now makes way more sense. I couldn't find this info even googling for half an hour.
Thank you.

Maybe this can be added as a Help button of some sort?

Comment 6

[Gintaras Žulys [:gzulys]]

Attachment: Bug 1634662 - Adds searching with attributeName=attributeValue in Inspector. r=#devtools-reviewers,nchevobbe

Comment 7

[Gintaras Žulys [:gzulys]]

Attachment: Bug 1634662 - Adds searching with attributeName=attributeValue in Inspector. r=#devtools-reviewers,nchevobbe

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c88797937acc
Adds searching with attributeName=attributeValue in Inspector. r=nchevobbe,devtools-reviewers

Comment 9

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/c88797937acc