1634663 - Declare callers of `Selection::GetRangeAt` `const` when possible

Status: RESOLVED FIXED

(Core :: DOM: Selection, enhancement)

Description

[Mirko Brodesser (:mbrodesser-Igalia)]

Helps to determine where, outside of Selection, ranges are mutated.

Comment 1

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1634663: part 1) Declare `Selection::GetRangeAt`'s callers `const` around dom/ code. r=masayuki

Only where possible, of course.

Comment 2

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1634663: part 2) Declare callers of `GetRangeAt` around `EditorBase` `const`. r=masayuki

Depends on D73444

Comment 3

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1634663: part 3) Declare callers of `Selection::GetRangeAt` in spellchecking code `const`. r=masayuki

Depends on D73445

Comment 4

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1634663: part 4) Declare callers of `Selection::GetRangeAt` `const` in layout code. r=masayuki

Depends on D73446

Comment 5

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1634663: part 5) Declare callers of `Selection::GetRangeAt` around toolkit/components/find `const`. r=masayuki

Depends on D73447

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5d49d672bcaa
part 1) Declare `Selection::GetRangeAt`'s callers `const` around dom/ code. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/3ba9cee0bfef
part 2) Declare callers of `GetRangeAt` around `EditorBase` `const`. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/e25aeed66e9a
part 3) Declare callers of `Selection::GetRangeAt` in spellchecking code `const`. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/e96619c151fc
part 4) Declare callers of `Selection::GetRangeAt` `const` in layout code. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/d102cc6d3daf
part 5) Declare callers of `Selection::GetRangeAt` around toolkit/components/find `const`. r=masayuki

Comment 7

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/5d49d672bcaa
https://hg.mozilla.org/mozilla-central/rev/3ba9cee0bfef
https://hg.mozilla.org/mozilla-central/rev/e25aeed66e9a
https://hg.mozilla.org/mozilla-central/rev/e96619c151fc
https://hg.mozilla.org/mozilla-central/rev/d102cc6d3daf