May 1 indexing failure
Categories
(Webtools :: Searchfox, defect)
Tracking
(Not tracked)
People
(Reporter: kats, Assigned: kats)
References
Details
Release indexer failed today, some output-file error. Needs investigation.
|
Assignee | |
Comment 1•4 years ago
|
||
The failure seems to be caused by a bug in the blame-skipping code, where if a hunk just has new lines added to the top of the file, the adjustment entry put into the line map here will look like (1, -1), (2, -2), etc.. This itself is fine, but then later we go to look up e.g. line number 1 in the line map here which gives us an old_lineno of 0, which then turns into -1 here for array indexing, and that obvious fails during array indexing.
The strange thing is this seems to be happening on a change from 2018 or so (this hunk specifically) so I don't see why this is failing now all of a sudden when it was working before.
|
|
Assignee | |
Comment 2•4 years ago
|
||
Ah, this is why: https://hg.mozilla.org/mozilla-central/rev/02cbfa7967b274d25d098b98fd3948a71e4e4821#l1.150
A new set of revs to ignore was added and that exposed this latent bug in the skip-blame code.
|
|
Assignee | |
Comment 3•4 years ago
|
||
|
|
Assignee | |
Comment 4•4 years ago
|
||
New indexer with the fix applied succeeded and deployed.
Description
•