Closed Bug 1634725 Opened 3 months ago Closed 3 months ago

[wpt-sync] Sync PR 23361 - Convert a CLS end to end test to wrap a WPT.

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox78 fixed)

RESOLVED FIXED
mozilla78
Tracking Status
firefox78 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(Depends on 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 23361 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23361
Details from upstream follow.

Steve Kobes <skobes@chromium.org> wrote:

Convert a CLS end to end test to wrap a WPT.

This unifies MetricIntegrationTest.LayoutInstability with the nearly
identical simple-block-movement.html, and introduces an abstraction for
communicating expectations from the WPT to the wrapper, so that they can
be verified in a generic way against the trace data and UMA/UKM results.

We'll use this technique for CLSAttribution_* in a follow-up.

Bug: 1045064
Change-Id: I401af5cd0186ad3de930130694ff2fcf7b43ed7e

Reviewed-on: https://chromium-review.googlesource.com/2175636
WPT-Export-Revision: 282a7e6a5941b06e94a6154c42b0c746468d62de

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 70 tests

Status Summary

Firefox

OK : 1
PASS: 69
FAIL: 1

Chrome

OK : 1
PASS: 1

Safari

OK : 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/layout-instability/simple-block-movement.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
Simple block movement.: FAIL (Chrome: PASS, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

/layout-instability/simple-block-movement.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a1684145f954
[wpt PR 23361] - Convert a CLS end to end test to wrap a WPT., a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6c679ef5a5f6
[wpt PR 23361] - Convert a CLS end to end test to wrap a WPT., a=testonly
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.