Closed Bug 1634810 Opened 2 years ago Closed 2 years ago

Update test262 blacklist for new RegExp features

Categories

(Core :: JavaScript Engine, task, P1)

task

Tracking

()

RESOLVED FIXED
mozilla78
Tracking Status
firefox78 --- fixed

People

(Reporter: iain, Assigned: iain)

References

Details

Attachments

(4 files)

In bug 1634135 we are enabling the new regexp engine, which lets us support dotAll, lookbehind assertions, and unicode property escapes. We should also enable the tests.

I'm landing this separately and slightly after bug 1634135 to keep things easier in the (hopefully unlikely) event that we need to back that bug out.

The cross-realm tests don't work with --more-compartments enabled. Now that the dotAll version of this test is enabled, it has to be added to the list.

Unicode property escapes allow regexps to match based on Unicode properties. Some of the test262 tests are quite large and slow, especially in the arm64 simulator: on my local machine, tests that took 1.7 seconds in native builds timed out after 150 seconds when simulated. This patch turns them off for arm64-simulator builds.

(V8 has encountered similar issues: https://github.com/v8/v8/blob/master/test/test262/test262.status#L778-L781)

Severity: -- → S3
Pushed by iireland@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2ac3987541b5
Part 1: Support new features in test262-update.py r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/eab0a87cca62
Part 2: Enable newly supported tests r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/3373d5410efc
Part 3: Add dotAll/cross-realm.js to jstests.list r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/73b1c6f87154
Part 4: Disable slow tests in arm64 simulator r=mgaudet
You need to log in before you can comment on or make changes to this bug.