1634814 - Firefox Reality can not use WebRender due to missing functionality in the OpenGL compositor

Status: RESOLVED INCOMPLETE

(Core :: Graphics: WebRender, defect)

Description

[Randall Barker [:rbarker]]

The pref gfx.webrender.force-disable no longer seems to work on Android and is forced on. This breaks Firefox Reality which can not use WebRender due to missing functionality found in the OpenGL compositor.

Comment 1

[Randall Barker [:rbarker]]

Works in GeckoView Nightly 77.0.20200429095105
Broken in GeckoView Nightly 77.0.20200430082621

Comment 2

[Randall Barker [:rbarker]]

Attachment: Decision Log Broken.

Comment 3

[Randall Barker [:rbarker]]

Attachment: Decision Log Working.

Comment 4

[Randall Barker [:rbarker]]

FxR issue https://github.com/MozillaReality/FirefoxReality/issues/3310

Comment 5

[Randall Barker [:rbarker]]

Actually, this isn't a WebRender issue, None of our prefs are getting set, the WebRender pref was just the most obvious. I will update.

Comment 6

[Randall Barker [:rbarker]]

FxR uses the user.js file to override prefs. This no longer works starting in GV 77.0.20200430082621.

Comment 7

[Randall Barker [:rbarker]]

Looks like we now need to use user_pref instead of pref.

Comment 8

[Darkspirit]

WebRender has been disabled in Firefox Reality: https://github.com/MozillaReality/FirefoxReality/issues/1859
I haven't found a bug about finding out what's going on or about reenabling it.

Comment 9

[Randall Barker [:rbarker]]

GeckoView allows the embedding application to define an offset when the Surface is registered (top and width). See:

https://searchfox.org/mozilla-central/rev/3262e013550a0db7c1840a78a3878a929801fe40/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoDisplay.java#50

Those values are used in the OpenGL compositor here:

https://searchfox.org/mozilla-central/rev/3262e013550a0db7c1840a78a3878a929801fe40/gfx/layers/opengl/CompositorOGL.cpp#1027

The logic is if there is an offset, the compositor uses a transparent color to clear. Then when the compositor renders, it sets the view port to start at the offset so that when it finishes, there is a transparent border around the content.

Comment 10

[u597032]

Firefox reality is no longer supported
https://blog.mozilla.org/en/mozilla/news/update-on-firefox-reality/

Comment 11

[Sören Hentzschel]

Firefox reality is no longer supported

Wolvic is still based on GeckoView (and, by the way, uses a much more recent version of GeckoView than the last version of Firefox Reality) so issues with WebRender on Firefox Reality / Wolvic still matter. So please don't close all Firefox Reality related issues just because of this announcement. Feel free to close issues if you confirmed that the issues no longer exist.