Closed
Bug 1634844
Opened 5 years ago
Closed 5 years ago
PDF_VIEWER_DOCUMENT_GENERATOR_2 is missing "other" key
Categories
(Firefox :: PDF Viewer, defect)
Firefox
PDF Viewer
Tracking
()
RESOLVED
FIXED
Firefox 78
| Tracking | Status | |
|---|---|---|
| firefox78 | --- | fixed |
People
(Reporter: jaws, Assigned: jaws)
References
Details
Attachments
(1 file)
I was seeing "Invalid string label" errors in my browser console so I filed bug 1634843 and wrote a patch to get better error messaging. This improved error messaging lead me to PDF_VIEWER_DOCUMENT_GENERATOR_2 which uses "other" as the default value but doesn't include "other" in the list of labels.
See https://searchfox.org/mozilla-central/rev/710d6e1015d03343b067b92e6f1f775a0b1cad6f/toolkit/components/telemetry/Histograms.json#9098 and https://searchfox.org/mozilla-central/rev/710d6e1015d03343b067b92e6f1f775a0b1cad6f/browser/extensions/pdfjs/content/web/viewer.js#1302-1303
|
Assignee | |
Comment 1•5 years ago
|
||
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/69fd88fac6a1
Add missing 'other' label to PDF_VIEWER_DOCUMENT_GENERATOR_2. r=chutten
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox78:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 78
You need to log in
before you can comment on or make changes to this bug.
Description
•