1634852 - nsTextFragmentVMX.cpp error: ISO C++17 does not allow 'register' storage class specifier

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Mikael Urankar]

Attachment: patch-dom_base_nsTextFragmentVMX.cpp

User Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:75.0) Gecko/20100101 Firefox/75.0

Steps to reproduce:

make

Actual results:

/usr/ports/www/firefox/work/firefox-76.0/dom/base/nsTextFragmentVMX.cpp:47:5: error: ISO C++17 does not allow 'register' storage class specifier [-Wregister]
register const vector unsigned short gtcompare =
^~~~~~~~~
/usr/ports/www/firefox/work/firefox-76.0/dom/base/nsTextFragmentVMX.cpp:56:7: error: ISO C++17 does not allow 'register' storage class specifier [-Wregister]
register vector unsigned short vect;
^~~~~~~~~

Expected results:

no error

clang90 -v
clang version 9.0.1
Target: powerpc64-portbld-freebsd13.0
Thread model: posix
InstalledDir: /usr/local/llvm90/bin

uname -a
FreeBSD host-10-8-43-160 13.0-CURRENT FreeBSD 13.0-CURRENT #0 r360467: Wed Apr 29 18:42:12 CEST 2020 xxx@xxx:/usr/obj/usr/src-ppc64/powerpc.powerpc64/sys/GENERIC64-NODEBUG powerpc

Comment 1

[Clara Guerrero ( Need Info Brindusa Tot Please)]

Hi,

We do not have right environment set up in order to reproduce this issue but I will set the component for it and maybe one of our developers will be able to reproduce it on their end.

Best,

Clara

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Thanks for the report! The patch looks good to me. Is there any chance you could send it using Phabricator, and with the right metadata? The patch references a .orig file which doesn't exist.

There's some docs for that in here, but let me know if you don't have the time or what not and I can write it and land it on your behalf.

Comment 3

[Mikael Urankar]

Attachment: Bug 1634852 - remove the register storage class specifier, it's deprecated in C++17.

Comment 4

[Mikael Urankar]

Attachment: Bug 1634852 - remove the register storage class specifier, it's deprecated in C++17.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/88c27f68efda
remove the register storage class specifier, it's deprecated in C++17. r=emilio

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/88c27f68efda