1634921 - network.cookie.sameSite.laxByDefault true will not redirect to the final url after entering password

Status: RESOLVED FIXED

(Core :: Networking: Cookies, defect, P2)

Description

[kernp25]

Attachment: KMAmL73cJk.mp4

From this Bug 1629436:

Logins seems to work now but there is still a bug.

After entering the password (the last step) it will redirect back to https://login.yahoo.com/ (look at the video).

Closing and opening the popup again, will load https://mail.yahoo.com/ correctly (because the login worked before).

Setting network.cookie.sameSite.laxByDefault to false will make the login work correctly (it will redirect to https://mail.yahoo.com/ after entering the password).

So it must have something to do with network.cookie.sameSite.laxByDefault true.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Rob Wu [:robwu]]

Could you try to create and share an isolated, self-contained test case that does not require logging in to Yahoo?

If not, could you at least capture the requests and note the URLs of the request, the request and response headers, and if available the cause?

Comment 3

[kernp25]

Attachment: console-export-2020-5-8_2-1-46.txt

network.cookie.sameSite.laxByDefault is false

Comment 4

[kernp25]

Attachment: console-export-2020-5-8_1-54-32.txt

network.cookie.sameSite.laxByDefault is true

Comment 5

[kernp25]

Attachment: console-export-2020-5-8_2-17-44.txt

network.cookie.sameSite.laxByDefault is true

Comment 6

[kernp25]

Attachment: console-export-2020-5-8_2-23-0.txt

network.cookie.sameSite.laxByDefault is false

Comment 7

[Rob Wu [:robwu]]

Thanks for the examples, I'm able to reproduce.

Comment 8

[Rob Wu [:robwu]]

Attachment: Bug 1634921 - Tests of same-site cookies after redirects in extensions

Comment 9

[Rob Wu [:robwu]]

Unassigning myself; I only provided unit tests to verify the bug.

I've started a discussion with :baku in https://phabricator.services.mozilla.com/D74504#2267394 . This will hopefully lead to a satisfactory solution.

Comment 10

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

The content of attachment 9145258 [details] has been deleted for the following reason:

Removed by request.

Comment 11

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

The content of attachment 9146650 [details] has been deleted for the following reason:

Removed by request.

Comment 12

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

The content of attachment 9146651 [details] has been deleted for the following reason:

Removed by request.

Comment 13

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

The content of attachment 9146652 [details] has been deleted for the following reason:

Removed by request.

Comment 14

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

The content of attachment 9146654 [details] has been deleted for the following reason:

Removed by request.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d7a3a1820600
Tests of same-site cookies after redirects in extensions r=baku

Comment 16

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/d7a3a1820600