1634988 - TypeError: state is undefined in toolkit/actors/BrowserElementParent.jsm

Status: RESOLVED FIXED

(Toolkit :: General, defect, P3)

Description

[kernp25]

Attachment: firefox_wCTdJaoWGc.png

I saw this error in the browser console: TypeError: state is undefined

My browser version: 75.0 (64-Bit)

Comment 1

[Mike Conley (:mconley) (:⚙️)]

We can probably just guard against state being undefined here.

Comment 2

[Varun [he/him IST]]

Hello. I would like to take this up

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Hi, Varun! Do you have a build of Firefox built already?

If so, I think what we want to do is handle the case where the state object doesn't exist right after here:

https://searchfox.org/mozilla-central/rev/227f22acef5c4865503bde9f835452bf38332c8e/toolkit/actors/BrowserElementParent.jsm#313

by adding:

if (!state) {
  return;
}

Comment 4

[Varun [he/him IST]]

Attachment: Bug 1634988 - guard state against being undefined in BrowserElementParent. r?mconley

Comment 5

[Varun [he/him IST]]

Hey Mike, I do have local build of Firefox with me. I have updated the changes at phabricator. I however could not find any tests for it. Let me know if something is missing.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b7b1979ea1d6
guard state against being undefined in BrowserElementParent. r=mconley

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/b7b1979ea1d6