1635050 - Implement something similar to urlclassifier.trackingAnnotationSkipURLs pref for REJECT_FOREIGN with exceptions

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, task)

Description

[Andrea Marchesini [:baku]]

We need a way to whitelist 3rd-parties when cookieBehavior is set to REJECT_FOREIGN + exceptions. To achieve this result, we need to:

1. whitelist any channel that matches at least 1 entry of urlclassifier.trackingAnnotationSkipURLs
2. whitelist any window with a document matching the same list.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: Bug 1635050 - Implement a whitelist system for cookieBehavior REJECT_FOREIGN with exceptions, r?dimi

Comment 2

[Andrea Marchesini [:baku]]

Attachment: Bug 1635050 - Implement a whitelist system for cookieBehavior REJECT_FOREIGN with exceptions - tests, r?dimi

Depends on D73615

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/451a90be5f40
Implement a whitelist system for cookieBehavior REJECT_FOREIGN with exceptions, r=dimi
https://hg.mozilla.org/integration/autoland/rev/fff7bc5ac710
Implement a whitelist system for cookieBehavior REJECT_FOREIGN with exceptions - tests, r=dimi

Comment 4

[Dorel Luca [:dluca]]

Backed out 2 changesets (bug 1635050) for XPCshell failures in /xpcshell/test_rejectForeignAllowList.js . CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=300738667&repo=autoland&lineNumber=5805

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=fff7bc5ac710edd1d4d478cc813ba0889fe2027a

Backout:
https://hg.mozilla.org/integration/autoland/rev/770d54c5653dbf6c77137e9bb8f208e746852ca7

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/68223def5ae0
Implement a whitelist system for cookieBehavior REJECT_FOREIGN with exceptions, r=dimi
https://hg.mozilla.org/integration/autoland/rev/74460d65e93b
Implement a whitelist system for cookieBehavior REJECT_FOREIGN with exceptions - tests, r=dimi

Comment 6

[Razvan Maries]

Backed out for perma failures on test_rejectForeignAllowList.js.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=NFZB7hj0T8GOSefyP1v3Mg-0&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=android%2C7.0%2Cx86-64%2Copt%2Cxpcshell%2Ctests%2Ctest-android-em-7.0-x86_64%2Fopt-geckoview-xpcshell-e10s-3%2Cx%28x3%29&revision=d2bb25cf6ed55b09585f40f102d514f679469c33

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=300875520&repo=autoland&lineNumber=2342

Backout: https://hg.mozilla.org/integration/autoland/rev/d90d95cbd444dbd77f34ff3c3b5871b65aff37bb

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e97bebb71cd
Implement a whitelist system for cookieBehavior REJECT_FOREIGN with exceptions, r=dimi
https://hg.mozilla.org/integration/autoland/rev/062b5f3c2b9d
Implement a whitelist system for cookieBehavior REJECT_FOREIGN with exceptions - tests, r=dimi

Comment 8

[Razvan Maries]

Backed out for xpcshell perma failures.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=MBlziDpQTZOuhOPxx1VG3A-0&resultStatus=testfailed%2Cbusted%2Cexception&revision=062b5f3c2b9dd4066a847df9b1a9b1fcba6f397f

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=300890076&repo=autoland&lineNumber=6082

Backout: https://hg.mozilla.org/integration/autoland/rev/2bda2d0f2200c5e38766f061a0ba41931f39d826

Comment 9

[Andrea Marchesini [:baku]]

Attachment: Bug 1635050 - UrlClassifierSkipListService calls the observers even when RemoteSettings have not been received yet, r?johannh

Comment 10

[Phabricator Automation]

Comment on attachment 9145919 [details]
Bug 1635050 - UrlClassifierSkipListService calls the observers even when RemoteSettings have not been received yet, r?johannh

Revision D73925 was moved to bug 1636371. Setting attachment 9145919 [details] to obsolete.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/62ac56e51fa7
Implement a whitelist system for cookieBehavior REJECT_FOREIGN with exceptions, r=dimi
https://hg.mozilla.org/integration/autoland/rev/b8e4f5d65b71
Implement a whitelist system for cookieBehavior REJECT_FOREIGN with exceptions - tests, r=dimi

Comment 12

[Natalia Csoregi [:nataliaCs]]

Backed out for failures on test_rejectForeignAllowList.js

backout: https://hg.mozilla.org/integration/autoland/rev/482cc7d0605c47687d89de9f371dd4f62e1b8080

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=b8e4f5d65b71fdd903a5d56ee8d53dddecf22774&group_state=expanded&selectedTaskRun=dHKzVE8ZTR2QMI7-5EqM8w-0

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=301380384&repo=autoland&lineNumber=6409

TEST-UNEXPECTED-FAIL | toolkit/components/antitracking/test/xpcshell/test_rejectForeignAllowList.js | xpcshell return code: 0
[..]
[task 2020-05-08T07:18:42.234Z] 07:18:42 INFO - TEST-PASS | toolkit/components/antitracking/test/xpcshell/test_rejectForeignAllowList.js | test_rejectForeignAllowList - [test_rejectForeignAllowList : 83] Cookies received? - "" == ""
[task 2020-05-08T07:18:42.234Z] 07:18:42 INFO - PID 12012 | [12012, Main Thread] WARNING: '!inner', file /builds/worker/checkouts/gecko/dom/ipc/JSWindowActorProtocol.cpp, line 172
[task 2020-05-08T07:18:42.234Z] 07:18:42 INFO - PID 12012 | [12012, Main Thread] WARNING: NS_ENSURE_TRUE(rootFrame) failed: file /builds/worker/checkouts/gecko/dom/base/nsGlobalWindowOuter.cpp, line 4324
[task 2020-05-08T07:18:42.235Z] 07:18:42 INFO - PID 12012 | [12012, Main Thread] WARNING: NS_ENSURE_TRUE(rootFrame) failed: file /builds/worker/checkouts/gecko/dom/base/nsGlobalWindowOuter.cpp, line 4324
[task 2020-05-08T07:18:42.235Z] 07:18:42 INFO - "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "Request to access cookie or storage on “http://3rdparty.org/iframe” was blocked because we are blocking all third-party storage access requests and content blocking is enabled."]"
[task 2020-05-08T07:18:42.235Z] 07:18:42 WARNING - TEST-UNEXPECTED-FAIL | toolkit/components/antitracking/test/xpcshell/test_rejectForeignAllowList.js | test_rejectForeignAllowList - [test_rejectForeignAllowList : 52] Cookies received? - "" == "cookie=wow"
[task 2020-05-08T07:18:42.235Z] 07:18:42 INFO - Z:/task_1588921096/build/tests/xpcshell/tests/toolkit/components/antitracking/test/xpcshell/test_rejectForeignAllowList.js:testThings:52
[task 2020-05-08T07:18:42.235Z] 07:18:42 INFO - exiting test
[task 2020-05-08T07:18:42.235Z] 07:18:42 INFO - Unexpected exception NS_ERROR_ABORT:
[task 2020-05-08T07:18:42.235Z] 07:18:42 INFO - _abort_failed_test@Z:\task_1588921096\build\tests\xpcshell\head.js:805:20
[task 2020-05-08T07:18:42.235Z] 07:18:42 INFO - do_report_result@Z:\task_1588921096\build\tests\xpcshell\head.js:906:5
[task 2020-05-08T07:18:42.235Z] 07:18:42 INFO - Assert<@Z:\task_1588921096\build\tests\xpcshell\head.js:67:21
[task 2020-05-08T07:18:42.235Z] 07:18:42 INFO - proto.report@resource://testing-common/Assert.jsm:233:10
[task 2020-05-08T07:18:42.235Z] 07:18:42 INFO - equal@resource://testing-common/Assert.jsm:275:8
[task 2020-05-08T07:18:42.236Z] 07:18:42 INFO - testThings@Z:/task_1588921096/build/tests/xpcshell/tests/toolkit/components/antitracking/test/xpcshell/test_rejectForeignAllowList.js:52:10
[task 2020-05-08T07:18:42.236Z] 07:18:42 INFO - asynctest_rejectForeignAllowList@Z:/task_1588921096/build/tests/xpcshell/tests/toolkit/components/antitracking/test/xpcshell/test_rejectForeignAllowList.js:141:9
[task 2020-05-08T07:18:42.236Z] 07:18:42 INFO - async_run_next_test/<@Z:\task_1588921096\build\tests\xpcshell\head.js:1582:22
[task 2020-05-08T07:18:42.236Z] 07:18:42 INFO - _run_next_test@Z:\task_1588921096\build\tests\xpcshell\head.js:1582:38
[task 2020-05-08T07:18:42.236Z] 07:18:42 INFO - run@Z:\task_1588921096\build\tests\xpcshell\head.js:749:9
[task 2020-05-08T07:18:42.236Z] 07:18:42 INFO - _do_main@Z:\task_1588921096\build\tests\xpcshell\head.js:242:6
[task 2020-05-08T07:18:42.236Z] 07:18:42 INFO - _execute_test@Z:\task_1588921096\build\tests\xpcshell\head.js:571:5
[task 2020-05-08T07:18:42.236Z] 07:18:42 INFO - @-e:1:1
[task 2020-05-08T07:18:42.236Z] 07:18:42 INFO - exiting test

Comment 13

[Andrea Marchesini [:baku]]

I forgot to set the dependency to bug 1635693 before landing the patches.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ca35e729ea3e
Implement a whitelist system for cookieBehavior REJECT_FOREIGN with exceptions, r=dimi
https://hg.mozilla.org/integration/autoland/rev/9ac5cff04d6c
Implement a whitelist system for cookieBehavior REJECT_FOREIGN with exceptions - tests, r=dimi

Comment 15

[Alexandru Michis [:malexandru]]

Backed out 2 changesets (Bug 1635050) for causing xpcshell failures in test_rejectForeignAllowList.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/ac7a5cda729f6f9d9c34463a1996b0bf06b9905f

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&fromchange=9ac5cff04d6c0bd739ee0dcc17425110b82f8b12&tochange=ac7a5cda729f6f9d9c34463a1996b0bf06b9905f&selectedTaskRun=EfGVe0oRRR-_hTkazNB7Bw-0

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=301404200&repo=autoland&lineNumber=5139

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/194144d29492
Implement a whitelist system for cookieBehavior REJECT_FOREIGN with exceptions, r=dimi
https://hg.mozilla.org/integration/autoland/rev/3fc14ac3b819
Implement a whitelist system for cookieBehavior REJECT_FOREIGN with exceptions - tests, r=dimi

Comment 17

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/194144d29492
https://hg.mozilla.org/mozilla-central/rev/3fc14ac3b819

Comment 18

[Andrea Marchesini [:baku]]

Comment on attachment 9145403 [details]
Bug 1635050 - Implement a whitelist system for cookieBehavior REJECT_FOREIGN with exceptions, r?dimi

Beta/Release Uplift Approval Request

• User impact if declined: We would like to run an experiment using REJECT_FOREIGN with exception in the next beta and this whitelist is needed.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This feature introduces a simple whitelist for hosts. It's low risk
• String changes made/needed: none

Comment 19

[Pascal Chevrel:pascalc]

There is no next beta, the next beta will be 78 beta 1 in a few days as we are in RC week for 77 and these patches landed in 78.

Comment 20

[Andrea Marchesini [:baku]]

I guess we cannot have these patches in 77. Is it OK for our experiments?

Comment 21

[Steven Englehardt [:englehardt]]

(In reply to Andrea Marchesini [:baku] from comment #20)

I guess we cannot have these patches in 77. Is it OK for our experiments?

That's okay, we can run the experiment during the 78 cycle. Thanks for trying to uplift!