Closed Bug 1635086 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 23383 - Add test that datachannel events are not fired after DC close.

Categories

(Core :: WebRTC, task, P4)

Product:
Core
Component:
WebRTC
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla78
Tracking Flags:
Tracking Status
firefox78 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 23383 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23383
Details from upstream follow.

Harald Alvestrand <hta@chromium.org> wrote:

Add test that datachannel events are not fired after DC close.

Addresses spec update:
https://github.com/w3c/webrtc-pc/pull/2521

Code was already fixed.

Bug: chromium:1069811
Change-Id: I6547c56a7ea11c2a024a57dd001f740cd9a1f681
Reviewed-on: https://chromium-review.googlesource.com/2179006
WPT-Export-Revision: 932d7d2f1c58b986d6213e89789005e18ef9e6e8

Component: web-platform-tests → WebRTC
Product: Testing → Core

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 70 tests

Status Summary

Firefox

PASS : 69
FAIL : 2
TIMEOUT: 2
NOTRUN : 1

Chrome

OK : 1
PASS : 4

Safari

FAIL : 2
TIMEOUT: 2
NOTRUN : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/webrtc/RTCDataChannel-close.html: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
Close datachannel causes onclosing and onclose to be called: FAIL (Chrome: PASS, Safari: FAIL)
Close datachannel causes closing and close event to be called: FAIL (Chrome: PASS, Safari: FAIL)
Close peerconnection causes close event and error to be called: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
Close peerconnection after DC close causes no events: NOTRUN (Chrome: PASS, Safari: NOTRUN)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3886f4322f2b [wpt PR 23383] - Add test that datachannel events are not fired after DC close., a=testonly https://hg.mozilla.org/integration/autoland/rev/d6c45563fc0a [wpt PR 23383] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3bad7b1c8552 [wpt PR 23383] - Add test that datachannel events are not fired after DC close., a=testonly https://hg.mozilla.org/integration/autoland/rev/36a2a1085d90 [wpt PR 23383] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/3bad7b1c8552
https://hg.mozilla.org/mozilla-central/rev/36a2a1085d90

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox78: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.