Wasm SIMD opcode renumbering + wat update
Categories
(Core :: JavaScript: WebAssembly, task, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox78 | --- | fixed |
People
(Reporter: lth, Assigned: lth)
References
Details
Attachments
(1 file)
The SIMD opcodes are being renumbered and we must follow (https://github.com/WebAssembly/simd/issues/216). We'll do this after we land SIMD for the baseline compiler but before SIMD for ion. The fix entails at least:
- update WasmConstants.h
- update some test cases that use the binary codes (eg wasm/binary.js)
- update wat and pull that in
It'll be useful to land all of these as a single stack to avoid testing failures that are otherwise inevitable.
Assignee | ||
Comment 1•4 years ago
|
||
Renumbers the SIMD opcodes in accordance with the latest proposal,
dropping the legacy shuffle opcode. Fixes a few binary tests.
Assignee | ||
Comment 2•4 years ago
|
||
The patch works with current tip of the wat repo. (However, mach vendor rust is broken so it took some shoehorning to test that, and I'm not going to land this patch until that problem has been fixed.)
Updated•4 years ago
|
Comment 3•4 years ago
|
||
This bug and bug 1635534 are co-dependent on the wat update. I was able to vendor it without issue on my patch stack, and can land all of these patches together when we're ready.
Pushed by rhunt@eqrion.net: https://hg.mozilla.org/integration/autoland/rev/64cd0f5e0585 Renumber the SIMD opcodes. r=rhunt
Comment 5•4 years ago
|
||
bugherder |
Description
•