Closed Bug 1635091 Opened 4 years ago Closed 4 years ago

Wasm SIMD opcode renumbering + wat update

Categories

(Core :: JavaScript: WebAssembly, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla78
Tracking Status
firefox78 --- fixed

People

(Reporter: lth, Assigned: lth)

References

Details

Attachments

(1 file)

The SIMD opcodes are being renumbered and we must follow (https://github.com/WebAssembly/simd/issues/216). We'll do this after we land SIMD for the baseline compiler but before SIMD for ion. The fix entails at least:

  • update WasmConstants.h
  • update some test cases that use the binary codes (eg wasm/binary.js)
  • update wat and pull that in

It'll be useful to land all of these as a single stack to avoid testing failures that are otherwise inevitable.

Renumbers the SIMD opcodes in accordance with the latest proposal,
dropping the legacy shuffle opcode. Fixes a few binary tests.

The patch works with current tip of the wat repo. (However, mach vendor rust is broken so it took some shoehorning to test that, and I'm not going to land this patch until that problem has been fixed.)

Depends on: 1636068
Attachment #9146436 - Attachment description: Bug 1635091 - Renumber the SIMD opcodes. r?rhunt → Bug 1635091 - Renumber the SIMD opcodes. r=rhunt

This bug and bug 1635534 are co-dependent on the wat update. I was able to vendor it without issue on my patch stack, and can land all of these patches together when we're ready.

Pushed by rhunt@eqrion.net:
https://hg.mozilla.org/integration/autoland/rev/64cd0f5e0585
Renumber the SIMD opcodes.  r=rhunt
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: