1635112 - Use `clang-tidy` as warning build error detector for our `static-analysis` targets.

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, task)

Description

[Andi [:andi]]

The purpose of this patch is to add support for build-error reporting through clang-tidy in order to drop the usage of Coverity for build-error reporting during review-phase.

Comment 1

[Andi [:andi]]

Attachment: Bug 1635112 - Use `clang-tidy` as warning build error detector for our `static-analysis` targets.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 3

[Andi [:andi]]

Attachment: Bug 1635112 - remove MSVC support from `WarningsCollector`. r=glandium

This was done in preparation to have build errors reporting at review-phase
based on clang-tidy.

Comment 4

[Andi [:andi]]

Attachment: Bug 1635112 - Disable the build error reporting at review-phase using `Coverity`. r=sylvestre,marco

Depends on D73692

Comment 5

[Andi [:andi]]

Attachment: Bug 1635112 - Mark `clang-diagnostic-error` as `publishable` in the `clang-tidy` artifact. r=sylvestre

For clang-tidy static-analysis mark all diagnostic-messages that are clang-diagnostic-error as publishable.

Depends on D74003

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d015b5e2ef8
remove MSVC support from `WarningsCollector`. r=glandium
https://hg.mozilla.org/integration/autoland/rev/8ade9f1318ba
Use `clang-tidy` as warning build error detector for our `static-analysis` targets. r=glandium
https://hg.mozilla.org/integration/autoland/rev/a9d5c0620a5b
Disable the build error reporting at review-phase using `Coverity`. r=sylvestre,marco
https://hg.mozilla.org/integration/autoland/rev/dfe30a835562
Mark `clang-diagnostic-error` as `publishable` in the `clang-tidy` artifact. r=marco

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/9d015b5e2ef8
https://hg.mozilla.org/mozilla-central/rev/8ade9f1318ba
https://hg.mozilla.org/mozilla-central/rev/a9d5c0620a5b
https://hg.mozilla.org/mozilla-central/rev/dfe30a835562