1635142 - Update sync-to-github script for upcoming Github API deprecation

Status: RESOLVED FIXED

(Core :: Graphics, task)

Description

[Kartikaya Gupta (email:[e-mail])]

https://developer.github.com/changes/2020-02-14-deprecating-password-auth/

I emailed github support to clarify:

Dominik Bamberger, May 4, 1:30 PM UTC

Hi,

Apologies for the time it took us to get back to you. We recently saw some of our support request queues overflow and we are slowly regaining control of the situation.

Yes, your cURL syntax will need to be adjusted to the following:

curl -H "Authorization: bearer YOUR_TOKEN"  https://api.github.com/...

No, Git commands like `git push` or `git pull` will be unaffected by the upcoming API change.

Let me know if you have any further questions.

Thanks,
Dominik

----------------------------------------------

Kartikaya Gupta (kats), Apr 12, 5:37 PM UTC

Two questions about the password authentication deprecation:
1. We currently use `curl -u user:token https://api.github.com/...` (i.e. using a personal access token, but for HTTP auth) which works fine. Will this also be removed?
2. What about pushes to git over https, e.g. `git push https://user:[e-mail]/... master`? Will this be deprecated as well, and if so, what is an alternative method for doing this? I don't believe that `git push` allows setting custom HTTP headers like the `Authorization` header.

Thanks!

Which means this line will be affected: https://searchfox.org/mozilla-central/rev/3262e013550a0db7c1840a78a3878a929801fe40/tools/github-sync/sync-to-github.sh#121

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1635142 - Update github-sync to use Authorization header instead of deprecated HTTP auth mechanism. r?kvark

Depends on D74066

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ca7d50f9d8f7
Update github-sync to use Authorization header instead of deprecated HTTP auth mechanism. r=kvark

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/ca7d50f9d8f7