163517 - Plugin info registry needs versioning

Status: RESOLVED INVALID

(Core Graveyard :: Plug-ins, defect)

Description

[av (gone)]

Anticipating that the newly introduced mechanism to cache plugin info in flat
registry file will be accepting additions and fixes in the nearest future, we
need to implement the total refresh of the file in the case the format becomes
incompatible with older versions.

Comment 1

[av (gone)]

Mechanism is already in place. Not clearly visible but working.

Comment 2

[serge (gone)]

well, it's clearly visible
just change the number
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/modules/plugin/base/src/nsPluginManifestLineReader.h&rev=1.1&root=/cvsroot#45

Comment 3

[av (gone)]

Under 'clearly visible' I meant that we don't check the error condition when
|nsPluginHostImpl::ReadPluginInfo| returns and don't use that failure as an
explicit flag indicating that the registry should be refreshed. I think one
would expect something like this in clearly written code.

Comment 4

[Peter Lubczynski]

What about when different version of the browser will be using the same file but
in different formats? For example, what if Mozilla 1.2 uses format A and Mozilla
1.3 uses format B. If using the same file, won't starting each version of the
browser cause us to invalidate the cache in a different way?

Comment 5

[av (gone)]

To my understanding, if any version of Mozilla sees the incompatible version, it
will just recreate the file in its own manner from the scratch. Serge, is it so?

Comment 6

[serge (gone)]

that is correct, pluginreg.dat will be overwritten if
[HEADER]
Version|major|minor
does not match hardcoded versions