1635243 - only use WS_EX_LAYERED | WS_EX_TRANSPARENT on the compositor window on nightly for now

Status: RESOLVED FIXED

(Core :: Graphics, task)

Description

[Timothy Nikkel (:tnikkel)]

We haven't shipped direct manipulation yet so we don't need these and they still cause blank windows for a very small number of users.

Comment 1

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1635243. Only use WS_EX_LAYERED | WS_EX_TRANSPARENT on the compositor window on nightly for now. r?sotaro

We haven't shipped direct manipulation yet so we don't need these and they still cause blank windows for a very small number of users.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3e58ffac4bb8
Only use WS_EX_LAYERED | WS_EX_TRANSPARENT on the compositor window on nightly for now. r=sotaro

Comment 3

[Timothy Nikkel (:tnikkel)]

Comment on attachment 9145612 [details]
Bug 1635243. Only use WS_EX_LAYERED | WS_EX_TRANSPARENT on the compositor window on nightly for now. r?sotaro

Beta/Release Uplift Approval Request

• User impact if declined: Completely blank Firefox window for some small percentage of users on quite old hardware (see bug 1632357 and bug 1544074).
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The riskier change is to keep WS_EX_LAYERED | WS_EX_TRANSPARENT. This change limits them to nightly. (We will need these eventually when Direct Manipulation is enabled, but it's not yet. Until then we can investigate work arounds/fixes.)
• String changes made/needed:

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/3e58ffac4bb8

Comment 5

[Pascal Chevrel (relman team) -> :pascalc]

Comment on attachment 9145612 [details]
Bug 1635243. Only use WS_EX_LAYERED | WS_EX_TRANSPARENT on the compositor window on nightly for now. r?sotaro

We are in early betas and this is good for retention, approved for 77 beta 2, thanks.

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/b6e80ba0f44e