1635261 - AntiTrackingUtils::HasStoragePermissionInParent() returns a wrong value in Fission

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, task, P1)

Description

[Tim Huang[:timhuang]]

The AntiTrackingUtils::HasStoragePermissionInParent() would returns a wrong value in Fission.

The reason is that we get the topLevelStorageAreaPrincipal from the channel. But, it is incorrect in Fission. To Fix this, we will not use the topLevelStorageAreaPrincipal, but to use the browsingContext and windowGlobalParent to get the principal we need since we are in the parent process when calling this function.

Comment 1

[Tim Huang[:timhuang]]

Attachment: Bug 1635261 - Modify the way how we get the top-level principal in AntiTrackingUtils::HasStoragePermissionInParent(). r?dimi

We used to use the topLevelStorageAreaPrincipal and topLevelPrincipal to
get the principal we need to do the storage permission checks in
AntiTrackingUtils::HasStoragePermissionInParent(). But, they don't work
in Fission. Also, we use these two principals to implicitly check if the
channel is top-level. This won't work as well.

So, we change to use the browsingContext to do the top-level check as
well as getting the top-level principal.

Comment 2

[Chris Peterson [:cpeterson]]

Tracking for Fission Nightly milestone (M6a) since this is work in progress.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/05ac80df0e76
Modify the way how we get the top-level principal in AntiTrackingUtils::HasStoragePermissionInParent(). r=dimi,baku

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/05ac80df0e76